[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] cmdline: only set ask mode if vga= is present
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 11 Jul 2023 11:14:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x+waXIC4Ec0IEes6IKMtmlXuM00CRnZGiWTjMJ49sBE=; b=V1NjPm+mBe58aHCDY24vKI5a9Qflrr2t8Ymu42jgTBRkv2egpg1m9WEEO6IbgzDN3YvosbUt9YEDXvarIEMHJRi6h0r6hli3FoIuxHVqfpYF9HvGN2F/iXHJCvE3lESiyrD/lgTga72tbDmI8UkZxx+6RI8hM53O3tLKlZhwUdMEn22eR2rfw7QrAF0E6G+37aDhzWTNyCN54L/JEVB5Xs6HzUsOAAaXplxHC8Oh2oPXocwZUcTVd+uMgTakmY/BjBOVyrGWhWzVHmrekZSmSj3iEAgBOlS+kc/g764jr0lc99jvElBgtfaygliPak5vgfzbGA+q2zVP+3Oi4FWqRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejjRm69GjpF9tMGNB+ZxkyEFBkemt+JlU9GhVE0N+XU6u3zyGWIF3uWLdhIzQmk6mS560FULlWo0ordXcN+9FG+4qcdOOOekRCO61+UKVztDUmLTBWqdHI941C1K2DzevGx5hnRGFhPFb9RD2L9zsPu/BFPcFeostCoPOGf2yGbbLkB0h9WvFE5muttCDbDZKi765jG4KFcpECZGlQPxSJGzi9qKmfYWUPbYRCzlyLoLY9D0/r7BLwb6hZFPAbBFJF9PgjLnOPXKqjR6Nk0vfd6P1NCGIjojSB+O9AUIrJkFruMNr5VE7DoZLe8baKO1qr9wddFr2ULKDJzp2GS/nQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 11 Jul 2023 09:14:58 +0000
- Ironport-data: A9a23:5ahtmazYJVjg/Njjpal6t+cRxyrEfRIJ4+MujC+fZmUNrF6WrkUDy 2ZODW+DbP3fYWCje4p/aITnoExQvJPXzIA3SQQ5qSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRhPKkT5TcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWhz9 u4SMTY9VxOGisLv7JGkQ8ZKqNt2eaEHPKtH0p1h5RfwKK9/BLvkGuDN79Ie2yosjMdTG/qYf 9AedTdkcBXHZVtIJ0sTD5U92uyvgxETcRUB8A7T+fVxvjaVlVIhuFTuGIO9ltiiX8Jak1zev mvb12/4HgsbJJqUzj/tHneE37aSzXmjA9pMfFG+3t87hlSdyDIzMx0bSleX5r6210iPZvsKf iT4/QJr98De7neDTNPwQhm5q36spQMHVpxbFOhSwB6J4rrZ5UCeHGdsZi5MbpkqudE7QRQu1 0SVhJX5CDp3qrqXRHmBsLCOoluP1TM9KGYDYWoPSlID6ty6+YUr1EuRHpBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPeRENXCzAS58Ebuk
- Ironport-hdrordr: A9a23:67idF64ROz7DM+Dn9APXwAzXdLJyesId70hD6qkQc3Fom62j5q WTdZEgvyMc5wx/ZJhNo7690cq7MBHhHPxOgbX5VI3KNGXbUQOTR72KhrGSoAEIdReeygZcv5 0QCZSXCrfLfCVHZRCR2njFLz4iquP3j5xBnY3lvhNQpZkBUdAZ0+9+YDzrdXFedU19KrcSMo GT3cZDryrIQwVtUizqbkN1OdQqvrfw5evbXSI=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Jul 10, 2023 at 06:27:06PM +0200, Jan Beulich wrote:
> On 10.07.2023 16:12, Roger Pau Monne wrote:
> > Commit 9473d9a24182 set the ASK mode without checking if there was a
> > `vga` option provided in the command line. This breaks existing
> > behavior, so exit early without changes if `vga` is not present in the
> > command line.
> >
> > Fixes: 9473d9a24182 ('cmdline: parse multiple instances of the vga option')
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Should have spotted this during review; effectively you're (almost) undoing
> part of the earlier change, just that ...
>
> > --- a/xen/arch/x86/boot/cmdline.c
> > +++ b/xen/arch/x86/boot/cmdline.c
> > @@ -279,9 +279,13 @@ static void vga_parse(const char *cmdline,
> > early_boot_opts_t *ebo)
> > {
> > const char *c = cmdline;
> >
> > + c = find_opt(c, "vga=", true);
>
> ... you use c instead of cmdline here (and I'm heavily tempted to actually
> make this the initializer of c).
I see, yes, please do.
Thanks, Roger.
|
