[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] xen/arm: Fix domain_handle_dtb_bootmodule() error path
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Tue, 11 Jul 2023 09:15:01 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btFhdzdGVwQJ4TZosIBJIEqkkmb25IwEuFAikTUp4P4=; b=FiP2v/zVYE5I3wQZY1vG7yJNdDiVfDksYD2JAHOdhG6u58egXMSmSM+uEnwBnKLZ1nrhttVrZv8qQ3kC9S19flmxPqSoGKedfdS2w2RK0KDBHpju3EZDbBFksyfISqb8JiU3/AQtdcJ75BBsyaMwOL73567JJOh/BJEeH6gSN3pZUuxXNoYyo3QG8FU//Si5Ywif5V15sG7bA7jotk1yTIRLGQRbF5bKAhldAitpjC3wAK4dlP582xLqAs3c3OaDbbtAVzH/pN7Rf945zBge7yomneJrCe70MJt0qxYuqJTDw59MUCAikU6J1NmGdvrYqsDPKtUZrOeWHoLAstqV1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bsPMYqMqwQHQ+CUU4w4mLd+dJuH/zi7dbDyN5NMrMbaBSVu0zPqlRQkIyxW4SPea5X4f8Dd1vKMgTEn+6rEYFV3JkjpoajrMwOpsPJN6sTZivRFOhCqDJ+fKSXqiuLskXixM5gL6dYet5ZAosZmzFtFoZpl6BAkcMXyuT2dIKfPfqS+grSra0pOoSUOX6muefx48GnFBAz5vOdXmm9mKcHIYrupN8g6BPKStwmI4H9vRWNVnStRbUcHMqwN0B/vY59MJpdiWtecsQa9Nz3nRypyoexUSx6sEN4+QpMBD+CuwIIERzD65awpP87kdnPJA/scT9G8sDzj+hXNZdvslRw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Tue, 11 Jul 2023 09:15:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZs9HrmE32Z8KSv0SIoy8VDf7goa+0SKYA
- Thread-topic: [PATCH 1/2] xen/arm: Fix domain_handle_dtb_bootmodule() error path
> On 11 Jul 2023, at 09:29, Michal Orzel <michal.orzel@xxxxxxx> wrote:
>
> Fix the error path in domain_handle_dtb_bootmodule(), so that the memory
> previously mapped is unmapped before returning the error code. This is
> because the function shall not make assumptions on the way of handling
> its error code in the callers. Today we call panic in case of domU
> creation failure, so having memory not unmapped is not a bug, but it can
> change.
>
> Similarly, fix prepare_dtb_domU() so that the memory allocated is freed
> before returning the error code from domain_handle_dtb_bootmodule().
>
> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
|
