Re: [PATCH 1/2] xen/arm: Fix domain_handle_dtb_bootmodule() error path

[Julien Grall <julien@xxxxxxx>]

Hi,

On 11/07/2023 10:15, Luca Fancellu wrote:
> > On 11 Jul 2023, at 09:29, Michal Orzel <michal.orzel@xxxxxxx> wrote:
> >
> > Fix the error path in domain_handle_dtb_bootmodule(), so that the memory
> > previously mapped is unmapped before returning the error code. This is
> > because the function shall not make assumptions on the way of handling
> > its error code in the callers. Today we call panic in case of domU
> > creation failure, so having memory not unmapped is not a bug, but it can
> > change.
> >
> > Similarly, fix prepare_dtb_domU() so that the memory allocated is freed
> > before returning the error code from domain_handle_dtb_bootmodule().
> >
> > Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
> Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
Acked-by: Julien Grall <jgrall@xxxxxxxxxx>

Cheers,

--
Julien Grall