[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 00/15] xen: fix violations of MISRA C:2012 Rule 7.2
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 12 Jul 2023 12:42:08 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CGIQzh1SUNfLLYTD++8e87ktMrg9m0u+487+hAjsAeA=; b=BA8sUaE4a+GEEMJ5aY3S9T22Sr+8+CSU6S12Ho38QG7uvPCocqRowsBH5mMrVZiYeNAPbQAf/hTIj/Ho3UF/FrvWHEDR/ajg3FQGEeiENn+YhKnPhzMDotZ+nmnRZv6dlYg7ENzhSTtKUfanH3/IV7bmfYk+0BEaMnB/lVrNZEyeurb+2/SEvD/CoDLxBob8z9Zw95eK0ozYcREXSTFbvzdevNY9vpz4mXUX37eQzDSXtqnouY9oTnyJyM5RyFIhlol1borJbqDaBiVtO2d/OtP6ITBCnAz0OFsRcL3Z/LeXB8DuGCDcB+Kg1dLUBTNcd2dDd3btwx+7ZrJ2GJeDwg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XC+7q9BaTnQHb2vXQ3FojEcG+huQDz1g0E5WJyc5nfcGCQq0mmO9lbQbnmwMGBT2LkY2P9ZDBrgcAUufdOr7Mfe9cV7O0yGoUS84vlETa9TbbsHpPjJBAv0F8YcL0eheeSei0n/7eLNNYuKPKpiKhh3ytBAmj0TN0ZXeo5Z8awh6gmpP+Lk5LeC37b0uedMy4n6TZPgOoJGd+cqZQCb/7yGOnZkdEU/lkYQqUXo1+mnlNZpXURYUzKuaw+wSoIatpFIMQLhDlQVDkKZQrZcg4XoXIZG8gb4d47DuPhjkvAkecWsX4e4CbzTVKGjhDyII1eF01mTsz+pGIul2Jb2EQA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <Xenia.Ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 12 Jul 2023 10:42:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.07.2023 12:32, Simone Ballarin wrote:
> Changes to macros 'X86_CR0_PG' and 'MSR_EFER' in files
> "xen/arch/x86/include/asm/x86-defns.h" and
> "xen/arch/x86/include/asm/msr-index.h"
> are not made since they are used also in assembly files.
I guess I overlooked this in earlier versions. There's no need to skip
such headers. You just can't attach U unconditionally; you need to use
_AC() (from xen/const.h), as msr-index.h already does in certain places.
Jan
|