[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v3 03/15] x86/svm: fix violations of MISRA C:2012 Rule 7.2


  • To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 12 Jul 2023 12:45:19 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+JPKHRKtLk0O0yYloJPncdmyXePya+s7YKuYK36KxW8=; b=QShToUUQXe0TlEPCcqKMu5wW/XzC5VTzW7D1m1noJGOxQgLKRphl8HgvUhDRLfXf/useUhb90FE8IsRVXx/L00YFjTvrapvf3nF0EZpf593dokMtcbLsrs67ioDB2uNdWL8JWDEBC+tCV6FXApHR5rus6pJC4TE36aA/t+GzIo684p7jjYX/7ullSwUKplicVOisMSlza3EeOBcpqtYWO/Q2m1or5m5qiagqkPB45ebTvQQVdmDh9BIzOWeQdqpsYTA7LUrRmYnJlikTL3sVjBXXmhWg00RZI2igI85CvuBsX0Ld6/Zrxo15gaYtPwVts0bIZqAtc8zn2q/QeppfwA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UWlaQxnHpy6xwcyMkDwf5UIH+yd1ijD3xPDcSY4CH065kG4WTr4P307OC1DzlYRpVlF1jNvBwgho8XoCHQVsdkiu7gay2aJor7EtbIRDv8gQ8aIkNfkY9clDb4Qa7q9qKfhUFHPC3h1+N2tSN3ScBCehlqPEHAx6OsxnHB0UAPhhJomHdjS4dtT3fERL+4spINQrm0QggyKMTFL5VyucU3bNjuvEy/HHDINwZOPo4qn0EQZLKrSQch/fzKCtBXHd8YWNkdTAE4DFMb5D90cHc8yTWGZ8IwSqVdqQx+qIAg+OsbQqE+4VIQSo+243bgPUTyKR4oPJt07z4FDk4mduRQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: consulting@xxxxxxxxxxx, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <Xenia.Ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 12 Jul 2023 10:45:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.07.2023 12:32, Simone Ballarin wrote:
> --- a/xen/arch/x86/hvm/svm/asid.c
> +++ b/xen/arch/x86/hvm/svm/asid.c
> @@ -16,7 +16,7 @@ void svm_asid_init(const struct cpuinfo_x86 *c)
>  
>      /* Check for erratum #170, and leave ASIDs disabled if it's present. */
>      if ( !cpu_has_amd_erratum(c, AMD_ERRATUM_170) )
> -        nasids = cpuid_ebx(0x8000000A);
> +        nasids = cpuid_ebx(0x8000000AU);

When resubmitting it would be really nice if you made changes that earlier
on were indicated could otherwise be done while committing.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.