[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/3] x86: allow Kconfig control over psABI level


  • To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 12 Jul 2023 15:01:15 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RwV3K5ru0fS/EaEyw2Eum6+kPBb6VamB7EOPgvTjmok=; b=fnWYB/IUjlbPyeOfl15Efss2Bwf7cnn93DJz8pZMsX5zq8RQWKKXHYwtn5kub5W7rWownrkGegU+JDd8JSGCttwNo8IBXqf/oythsaIvMxbUeB7x+MHumuuWvho3Zic6UmTTpS/wENI7i0FWZel8lGj59aqbyRqT+glMSv6CBVCOdZPQ0soJ0D88bu4S30ui+3OOruYJzj6lu/2xy6MS/ztNfpO86KzQktxVLR6l8K7Na/+qe7RBOfVV9+rnEYksoF3iHwUqg5LwNpL17ihSVc7at0M/8UeLMxQcqxewlkz62H5wly1usz5gnCSv2XSDs19cnKOkiRlXFlIQb0S7Og==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RQn5bXSOM5xU7XNIFQ9XdMsEvkEL+kT/ye7DY58Szuy/FzohH4avT+iXX9nQYlYio8valJBHZa9TDjI8g+3PUQeSrvIZ5Wpv8QcLA3nqiXxhbcWG6u72Bq9o2FerPD+ZnJ6WF6AGIq/Kykn9OF+R1cEOS4nqm4urr5rmOeFMCNE6v3fpzGKmCXQm5MbNLCkQm/5FdDxN8WlxIT8lrCGOg9tSuaJJM4mM7yRVVHcXgga3lI/Bi97Lx16wiG8MMuD4kM2RzOtN/2YGL7ElFBxzLnGLG9sl0qgPlpuSZPvLNJxS7XzJWHDsd7mP/u3ZAHZzJT4b2nHSb5CkDBVDE/W1mQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Wed, 12 Jul 2023 13:01:31 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 12.07.2023 14:33, Jan Beulich wrote:
> --- a/xen/arch/x86/arch.mk
> +++ b/xen/arch/x86/arch.mk
> @@ -36,6 +36,10 @@ CFLAGS += -mno-red-zone -fpic
>  # the SSE setup for variadic function calls.
>  CFLAGS += -mno-mmx -mno-sse $(call cc-option,$(CC),-mskip-rax-setup)
>  
> +# Enable the selected baseline ABI, if supported by the compiler.
> +CFLAGS-$(CONFIG_X86_64_V2) += $(call cc-option,$(CC),-march=x86-64-v2)
> +CFLAGS-$(CONFIG_X86_64_V3) += $(call cc-option,$(CC),-march=x86-64-v3)

Hmm, I should have remembered that this won't work with older gcc,
because of how $(cc-option ...) works. I recall someone else already
fell into this trap a few years ago, but then they weren't following
up on the suggestions on how to make their somewhat fragile workaround
more robust. Now I'm on the hook ...

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.