[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] drm: Explicitly include correct DT includes
- To: Rob Herring <robh@xxxxxxxxxx>
- From: Steven Price <steven.price@xxxxxxx>
- Date: Mon, 17 Jul 2023 09:19:59 +0100
- Cc: devicetree@xxxxxxxxxxxxxxx, Ondrej Jirman <megous@xxxxxxxxxx>, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, etnaviv@xxxxxxxxxxxxxxxxxxxxx, linux-samsung-soc@xxxxxxxxxxxxxxx, linux-mips@xxxxxxxxxxxxxxx, lima@xxxxxxxxxxxxxxxxxxxxx, linux-mediatek@xxxxxxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linux-arm-msm@xxxxxxxxxxxxxxx, freedreno@xxxxxxxxxxxxxxxxxxxxx, linux-rpi-kernel@xxxxxxxxxxxxxxxxxxx, linux-renesas-soc@xxxxxxxxxxxxxxx, linux-rockchip@xxxxxxxxxxxxxxxxxxx, linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx, linux-sunxi@xxxxxxxxxxxxxxx, linux-tegra@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, Liviu Dudau <liviu.dudau@xxxxxxx>, David Airlie <airlied@xxxxxxxxx>, Daniel Vetter <daniel@xxxxxxxx>, Andrzej Hajda <andrzej.hajda@xxxxxxxxx>, Neil Armstrong <neil.armstrong@xxxxxxxxxx>, Robert Foss <rfoss@xxxxxxxxxx>, Laurent Pinchart <Laurent.pinchart@xxxxxxxxxxxxxxxx>, Jonas Karlman <jonas@xxxxxxxxx>, Jernej Skrabec <jernej.skrabec@xxxxxxxxx>, Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>, Liu Ying <victor.liu@xxxxxxx>, Shawn Guo <shawnguo@xxxxxxxxxx>, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>, Pengutronix Kernel Team <kernel@xxxxxxxxxxxxxx>, Fabio Estevam <festevam@xxxxxxxxx>, NXP Linux Team <linux-imx@xxxxxxx>, Inki Dae <inki.dae@xxxxxxxxxxx>, Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>, Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>, Maxime Ripard <mripard@xxxxxxxxxx>, Thomas Zimmermann <tzimmermann@xxxxxxx>, Lucas Stach <l.stach@xxxxxxxxxxxxxx>, Russell King <linux+etnaviv@xxxxxxxxxxxxxxx>, Christian Gmeiner <christian.gmeiner@xxxxxxxxx>, Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx>, Kyungmin Park <kyungmin.park@xxxxxxxxxxx>, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>, Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, Xinliang Liu <xinliang.liu@xxxxxxxxxx>, Tian Tao <tiantao6@xxxxxxxxxxxxx>, Xinwei Kong <kong.kongxinwei@xxxxxxxxxxxxx>, Sumit Semwal <sumit.semwal@xxxxxxxxxx>, Yongqin Liu <yongqin.liu@xxxxxxxxxx>, John Stultz <jstultz@xxxxxxxxxx>, Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx>, Paul Cercueil <paul@xxxxxxxxxxxxxxx>, Qiang Yu <yuq825@xxxxxxxxx>, Paul Kocialkowski <paul.kocialkowski@xxxxxxxxxxx>, Linus Walleij <linus.walleij@xxxxxxxxxx>, Chun-Kuang Hu <chunkuang.hu@xxxxxxxxxx>, Philipp Zabel <p.zabel@xxxxxxxxxxxxxx>, Matthias Brugger <matthias.bgg@xxxxxxxxx>, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>, Kevin Hilman <khilman@xxxxxxxxxxxx>, Jerome Brunet <jbrunet@xxxxxxxxxxxx>, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>, Rob Clark <robdclark@xxxxxxxxx>, Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>, Dmitry B aryshkov <dmitry.baryshkov@xxxxxxxxxx>, Sean Paul <sean@xxxxxxxxxx>, Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>, Marek Vasut <marex@xxxxxxx>, Stefan Agner <stefan@xxxxxxxx>, Sam Ravnborg <sam@xxxxxxxxxxxx>, Jerry Han <hanxu5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>, Icenowy Zheng <icenowy@xxxxxxx>, Ondrej Jirman <megi@xxxxxx>, Javier Martinez Canillas <javierm@xxxxxxxxxx>, Guido Günther <agx@xxxxxxxxxxx>, Purism Kernel Team <kernel@xxxxxxx>, Jianhua Lu <lujianhua000@xxxxxxxxx>, Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>, Broadcom internal kernel review list <bcm-kernel-feedback-list@xxxxxxxxxxxx>, Artur Weber <aweber.kernel@xxxxxxxxx>, Tomeu Vizoso <tomeu.vizoso@xxxxxxxxxxxxx>, Alyssa Rosenzweig <alyssa.rosenzweig@xxxxxxxxxxxxx>, Emma Anholt <emma@xxxxxxxxxx>, Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>, Sandy Huang <hjc@xxxxxxxxxxxxxx>, Heiko Stübner <heiko@xxxxxxxxx>, Orson Zhai <orsonzhai@xxxxxxxxx>, Baolin Wang <baolin.wang@xxxxxxxxxxxxxxxxx>, Chunyan Zhang <zhang.lyra@xxxxxxxxx>, Alain Volmat <alain.volmat@xxxxxxxxxxx>, Yannick Fertre <yannick.fertre@xxxxxxxxxxx>, Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx>, Philippe Cornu <philippe.cornu@xxxxxxxxxxx>, Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx>, Alexandre Torgue <alexandre.torgue@xxxxxxxxxxx>, Chen-Yu Tsai <wens@xxxxxxxx>, Samuel Holland <samuel@xxxxxxxxxxxx>, Thierry Reding <thierry.reding@xxxxxxxxx>, Mikko Perttunen <mperttunen@xxxxxxxxxx>, Jonathan Hunter <jonathanh@xxxxxxxxxx>, Jyri Sarha <jyri.sarha@xxxxxx>, Tomi Valkeinen <tomba@xxxxxxxxxx>, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
- Delivery-date: Mon, 17 Jul 2023 08:21:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14/07/2023 18:45, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it as merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
[...]
> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c
> b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index bbada731bbbd..20c25c836198 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -4,8 +4,9 @@
> /* Copyright 2019 Collabora ltd. */
>
> #include <linux/module.h>
> -#include <linux/of_platform.h>
> +#include <linux/of.h>
> #include <linux/pagemap.h>
> +#include <linux/platform_device.h>
> #include <linux/pm_runtime.h>
> #include <drm/panfrost_drm.h>
> #include <drm/drm_drv.h>
Panfrost part:
Reviewed-by: Steven Price <steven.price@xxxxxxx>
Steve
|