[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86: drop old (32-bit-only) MSR definitions


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Mon, 17 Jul 2023 11:33:09 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BMCAIWnR94lxNyTfBZ3Asp56scvrJYvkRyhDpqroCB0=; b=XEFNilYw7tacQgiYG0bAlbspT+sweD4kqGwBn1p66lS0dKwgGIrBSX2pOxg1R3B2uoxtmJOZvAHo8Vtri9cREqt9z7D2oRpoeFE4wDHBMHWhkGUYTJeZi0HhYpV331wtG2OlebG1fcYsHeriwhCW21xDRSRXlO4EBjAuWs59/GS0TzmbmH4b7S2fwWBi35iDNjQkZSt93PuW12T/VcS0ftiYKiqwA9mnNJETkbBjJM3ic8VxW0sPaQkgMIbI6b1RyFiU3TJEEI6L0Ytr42fPd0nt56xXO9PlKBLc2Nuu4VlXdBo1FsDGHQlyAoCRWzRdahojBgVQW+UJJlEeQNaOrA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LgDOnPvGdA7OU3Lz9meWGoSYAUVkp2fXd9DqIt/qYgwwsIDjAEE9d2GEqsH1r3IhTlA4+ub3xdtI+DfdUlW8X4s/1A29BkjFYP1mePBFIbof8jSz65JxgHY+m1UKkb/Em9TVtDyjb5THC1U/q0tO1pWBHvO/mdjQMq9ANb051olQhPez1jUvMkRcgqVr6Mq0S8k+dWxYIUKRyzXwFYX12LsQuWhOndtvCcCf0lvQmh1IHwhjZwSqxLFJya5SKXkeAwkM/k+5yZtFjv+vrs86nRcDWQoqJzu7hmi7s2Q/yVjgUBQOxo4ujMQEhDCLuc4/HGjLgwaJMif4QQFJCkF4vQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Simone Ballarin <simone.ballarin@xxxxxxxxxxx>, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • Delivery-date: Mon, 17 Jul 2023 10:33:58 +0000
  • Ironport-data: A9a23:nCrcA6hKR1uvKr93CkMkvi9OX161mBEKZh0ujC45NGQN5FlHY01je htvCmqFbKmJZzT9eIsgPomz8xlQ6MXcy4MwTwc9+CtnFHwb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrWCYmYpHlUMpB4J0XpLg/Q+jpNjne+3CgaMv cKai8DEMRqu1iUc3lg8sspvkzsx+qyr0N8klgZmP6sT4waBzyB94K83fsldEVOpGuG4IcbiL wrz5OnR1n/U+R4rFuSknt7TGqHdauePVeQmoiM+t5mK2nCulARrukoIHKN0hXNsoyeIh7hMJ OBl7vRcf+uL0prkw4zxWzEAe8130DYvFLXveRBTuuTLp6HKnueFL1yDwyjaMKVBktubD12i+ tQBMT4IRDHYwNnm6/WfR6pVttYFHdHkadZ3VnFIlVk1DN4AaLWaGuDgw48d2z09wMdTAfzZe swVLyJ1awjNaAFOPVFRD48imOCvhT/0dDgwRFC9/PJrpTSMilEhluGzYbI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTprqQ63QDProAVICE5aQe8gfnntn6/UugCe mwFqhI385FnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakcsVgoA5N/u5os6ihbGVNdlOKSogcb4Hz62y DePxAAxhrwVidMA3uO/4EjOmTOqp7DDUwEu6wPYGGmi62tRf5W5boal7Vza6/doL4uDSFSF+ n8elKCjAPsmCJiMkGmHRrULFbTwvvKdamSC0BhoAoUr8Cmr9zi7Z4dM7TpiJUBvdMEZZTvuZ 0yVsgRUjHNOAEaXgWZMS9rZI6wXIWLIT4qNuiz8BjaWXqVMSQ==
  • Ironport-hdrordr: A9a23:VPcTFa1rFz/5QPSoIyKPyAqjBa9xeYIsimQD101hICG9Lfb0qy n+pp4mPEHP4wr5OEtOpTlPAtj4fZquz+8T3WB3B8beYOCGghrTEGgG1+ffKlLbak7DH4JmpM Jdmu1FeabN5DtB/LjHCWuDc+rIqePvmM7IuQ6d9QYUcegDUdAe0+4TMHf+LqQZfnghOXN0Lu v/2iIRzADQBUj/I/7LTkXsGIP41q/2vaOjRSRDKw8s6QGIgz/twLnmEyKA1hNbfyJTzawk+W 3llRW8wqm4qfm0xjLVymeWtv1t6Zfc4+oGIPbJptkeKz3qhArtTIN9W4eatDRwjPCz5E0smN zspQ5lG8ho8Xvecky8vBOo8Qj91zQF7WPk1Daj8DbeiP28YAh/J9tKhIpffBecw008vOtk2K YO+26CrZJYAT7JgSy4vrHzJltXv3vxhUBnvf8YjnRZX4dbQLhNrbYH9EcQNJsbBir15K0uDe ErJsDB4/R9d0+cchnizyJS6e3pek52MgaNQ0AEtMDQ+z9KnEphx09d/8AblmdozuNLd7B0o8 D/doh4nrBHScEbKYhnAv0afMexAmvRBTrRLWO7Oz3cZeE6EkOIj6SyzKQ+5emsdpBN5oA1go 79XFRRsnN3U17yCPeJwIZA/nn2MSSAtAzWu4NjDqVCy/jBrOKBC1zGdLluqbrvnxwnOLyZZx 7pU6gmRMMKLgPVaPJ0NkPFKt9vwEIlIb4oU+YAKiOzS/3wW/3XX8zgAYDuzenWYH8Zc1K6JE c/dx7OA+gFxnyXexbD8W3ssjXWCwPCwa4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 17/07/2023 10:17 am, Jan Beulich wrote:
>  /* Intel defined MSRs. */
> -#define MSR_IA32_P5_MC_ADDR          0x00000000
> -#define MSR_IA32_P5_MC_TYPE          0x00000001

These are architectural.  They still exist in all Intel and AMD CPUs.

I'd suggest keeping them, because I think we're required to expose them
when advertising MCA.

Otherwise, LGTM.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.