[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 2/3] xen/ppc: Implement early serial printk on pseries



Quick followup,

On 7/17/23 1:32 PM, Shawn Anastasio wrote:
> On 7/17/23 11:17 AM, Jan Beulich wrote:
>> This could do with using ARRAY_SIZE(rets). Same again below.
> 
> Sure, will do this.

ARRAY_SIZE is defined in <xen/lib.h> which can't yet be included due to
missing headers. I could copy its definition into this file along with a
TODO comment to fix it once the include works.

If I were to go down that route, I'd also probably not include the
__must_be_array assertion and related machinery that the <xen/lib.h>
version has, since it'd require a large portion of <xen/lib.h> to be
copy/pasted.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.