[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] xen/ppc: Implement early serial printk on pseries
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Jul 2023 08:41:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rA7UTSu9LQtNU+NdEy7mQ8uuODWbKRlS/Zmmie54Nes=; b=FTkDpAJEGMJmICUzoCV9nnD360OR5+uZM3ApYNYRAUnkD85g1b1c0KNfX2V/5SmVeo9G4teEGd1pEhcDS8Bboo30EQwtTCnTyEU3d95Qd7X4Riu6VxcIjadrrPkM+ZSYzu2IsaY/43jmOYU0zjmzmXj4DaArQtJ+1D03ejMwgsr18jr2anZEPUQ7hhsxFLSw5OgJxOoPPcFXrhr8vIEEYhLEm/uEjoSy1aW3mXSwpF2GkGcbgVZd9TrFuAUQXuh/CEUC0UfSGP2EtAg4PgwbZ7amz8tDz7zDhdDKuiyUIcoHY2JSBmyomeBxFI2iYJW19HpVfxKsLKNJOEdMUKNsdQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I8acpD8sfyKEZLZNqLjfn0U32cYq12cmEUvGS8w27c5k5tRcopLcPUHHukS6GcWzUmCqU9Li0MrsZ9fzfRVAepEQwkrq6PUnlHvwQY6KURqvO3lgS9T4ScFrsmHc6neBvom1vuANrzuNEaCMWP+gjYzSDw9HhfaunbrB4Blh5ndZmhvCe6op8QWeJzY7P5Tkxgk2LpyMUrOXKb4z63cqtVziKzRkvDwpyXDGVklJ6JiKVYhLwRRp4o0rEdnWiev+QrM7NxXaV/TJcaW6zWpgZpioEX1EIAP/se92sD+VT+vOyskQP9s83vKsLdw04YbwBarZe3hL1JvJ7ndSlHjmVg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 18 Jul 2023 06:41:40 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.07.2023 20:40, Shawn Anastasio wrote:
> Quick followup,
>
> On 7/17/23 1:32 PM, Shawn Anastasio wrote:
>> On 7/17/23 11:17 AM, Jan Beulich wrote:
>>> This could do with using ARRAY_SIZE(rets). Same again below.
>>
>> Sure, will do this.
>
> ARRAY_SIZE is defined in <xen/lib.h> which can't yet be included due to
> missing headers. I could copy its definition into this file along with a
> TODO comment to fix it once the include works.
>
> If I were to go down that route, I'd also probably not include the
> __must_be_array assertion and related machinery that the <xen/lib.h>
> version has, since it'd require a large portion of <xen/lib.h> to be
> copy/pasted.
You (like anyone else) could review (and then offer R-b) my "common:
move a few macros out of xen/lib.h" [1]. That's of course only a tiny
first step (covering little more that what I need in that series). You
(or I or anyone else) could then put a patch on top moving ARRAY_SIZE()
(and its prereqs) to the new header as well. Since the new header has
no other prereqs, it should be usable as is, without the need for any
arch headers, both here and similarly in the RISC-V work.
Jan
[1] https://lists.xen.org/archives/html/xen-devel/2023-07/msg00582.html
|
