[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/8] build: Remove CONFIG_HAS_PDX
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Jul 2023 11:19:57 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EQCE1f9ksBOKVEgge7qIuKKq9qO4QWavw3NBoBaHnME=; b=LovbGuOmNL4rozw5Mp1+ZWmjtAWVCuG7hmR78gIx58onqZxmKgtI+MUUSgBaNo6+RxOfrFHS0w2hv4AYwZ34JHX1DJ8nwAH1LYwRINcOKPqZLOB/x/EMWANlDCuU7q97cZ9z//PUjiCv51W2u5rs4DCNRofB9M4AF3I0DojiZxGde58guz70sGMOe4ruvpCTByoMxUeDO+bOcAc1rrHpIRb6n8gV41dQ/jT6+ur66Gq37ZLRsoJd8Z4kH6Qxi0/jlu/jSG3/TJS+7REbTlztrI21/OfD+vh6vIXI4fVs7TF0faD4l7cobLS40GKrQf5GudC35TE6Jff+s/6uVkbp4g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dKFDXSBufWa4z5msnKa0EuiFrFJuHkTUQPs5dYoubd7Ut87Sd0DrRD15uNB4nL4BEmGJDh05PceAy/wgDZ7zk2uHl0CPLzu3ez1OdHQgiw6WufW6LKiuBN2Yhn5cQFrXpC+rK5SYyrMDy8e0ED0WBbAscZeAVFgb7YV7CVmFVLBut+q/ZdCqvnDQFSmZRuY+bw1NEQDzj3vp7v0SWtDKowIfpDTH3h2uaofyMvHnIv511oYT/2XsV9wnBTvRVi8PZYRD1aGY0hZDgGCb2Rwb0dGTwJrIwRWXucex+Dh3k/iu/y0jrRSGg3s4+chTSxrvpqMmCGjqXMbu5UaI1Xdf2w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 18 Jul 2023 09:20:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.07.2023 18:03, Alejandro Vallejo wrote:
> It's set everywhere and can't be turned off because it's presence is
> assumed in several parts of the codebase. This is an initial patch towards
> adding a more fine-grained CONFIG_HAS_PDX_COMPRESSION that can actually be
> disabled on systems that don't typically benefit from it.
>
> No functional change.
>
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
On its own I don't think this is okay, as it's unclear whether it would
affect RISC-V or PPC in a negative way. If at all, it should only go in
together with the later re-introduction of a CONFIG_*. Still I question
whether that new CONFIG_HAS_PDX_COMPRESSION (which imo ought to be
CONFIG_PDX_COMPRESSION) then wouldn't better depend on the arch-selected
HAS_PDX, such that it wouldn't wrongly be offered to choose a value when
compression isn't supported in the first place.
Jan
|
