[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/8] build: Remove CONFIG_HAS_PDX
- To: Jan Beulich <jbeulich@xxxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 18 Jul 2023 10:35:03 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TtLv1TAeU+RBC6K3oID2uq6T2gCwle8imeXUz77rNpA=; b=Yk7u9VcKOHorsnbg6iF/orazo0BhzR59cJvJo5wFrUZq4rdxU68OdtcBjhjgauE9vJgLv49IfUGAD/e3PArQmUe3+nQ4hH4xenv4XGj1bb/0SHJFgpGet8l+7MMZLnlwTHQSnn33taOvtWACLvSYupuGGvj75M++cuuZ3KWHs2AWP6FG7gh2Za48EgD8yJMV5CZxm+EWuoIFkNNiG44Xf+9RSR1PdqYQG3blPtLJb50/keJjwNHmLJczBiBQGj1UALATNCRV/x5ELoBZ/U3sIJZMKS4Kp0akt4/Etz1ZB+eZgYbKSrdnjF99DnphQavQs5WpBVoa7xBQiopEK9wwuA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BLdkYhCa+pfsznKie0ftPQuLP9QHnv52HDmlr2NXr7rQN6dZjzVRPBp5dRmGlTywT2v5awANbZJR35UPNaINC40Dra1t0qpnSR7wyY8l2MEEuJ72GhkCTlAAnQ9nfFy22XjZrtnZ7CPl3j/zGmkPn5LYU5XRAOPue9FjUuxKOs3j9gK+owQZDSXwMcJ2rpdKYlKIVVgPzH2P5yS6Z1OAAY5d+N98PVtNM3n5ehW349581pek6jmA0vvvIm5TzdswmCs/sC//hX1g6Lwzddxwqh5APmyLfhc5jtJMpd5ZI+Q9etc6r5If7AeolJmW1ylfWGvhVxF3m/qGRYHeYNR0tw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 18 Jul 2023 09:35:30 +0000
- Ironport-data: A9a23:VlO0vKlAdjaJNCEPs/VdeJXo5gwnJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xIZXT2Ba63fMGP0KtxxPo+yoUMFscPSx4NgTwY+/ngyRSMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgU5Q+GzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 ewiAhQ8ZSKovOSr3Lm9c+dgosMAN9a+aevzulk4pd3YJdAPZMmaBo7tvJpf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVI3ieewWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTeDiqaMz0A37Kmo7VhI7TX63nKaCtlOEafd9D lA3ygkelP1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xD2wJTDdHZMYh8tE/QTgn1 FihlNfuGDApu7qQIVqG7audpz62PSkTLEcBaDUCQA9D5MPsyKkxkxbOQ9BLAKOzyNrvFlnYy T2QsDI3gblViMcRzri65njOmTfqrZ/MJiYL4QHQUnOg/xlOToevbIy16nDW9f9Fao2eSzGpo 3wsi8WYqucUAvmlhCGLBekAArytz/KEKyHHx05iGYE78Dag8GLleppfiAySP29sO8cAPDTuO UnavFoI4IcJZST3K6hqf4i2FsImi7D6EsjoXezVadwIZYVtcAiA/2dlYkv4M33RrXXAWJoXY f+zGftAx15AYUi75FJan9sg7II=
- Ironport-hdrordr: A9a23:tb2G/6PXceuUZsBcTsKjsMiBIKoaSvp037Dk7TEXdfU1SL3/qy nKpp4mPHDP+VUssR0b+exoW5PgfZq/z+8W3WB5B97LNzUO01HYSb2Kg7GSpwEI2BeTygee78 pdmmRFZ+EYxGIVsfrH
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18/07/2023 10:19 am, Jan Beulich wrote:
> On 17.07.2023 18:03, Alejandro Vallejo wrote:
>> It's set everywhere and can't be turned off because it's presence is
>> assumed in several parts of the codebase. This is an initial patch towards
>> adding a more fine-grained CONFIG_HAS_PDX_COMPRESSION that can actually be
>> disabled on systems that don't typically benefit from it.
>>
>> No functional change.
>>
>> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> On its own I don't think this is okay, as it's unclear whether it would
> affect RISC-V or PPC in a negative way.
Neither could compile without layering violations of PDX logic in common
code, and neither have got that far yet.
Now is an excellent time to be doing this, because it removes work for
RISC-V/PPC...
> If at all, it should only go in
> together with the later re-introduction of a CONFIG_*. Still I question
> whether that new CONFIG_HAS_PDX_COMPRESSION (which imo ought to be
> CONFIG_PDX_COMPRESSION) then wouldn't better depend on the arch-selected
> HAS_PDX, such that it wouldn't wrongly be offered to choose a value when
> compression isn't supported in the first place.
... although I do agree that the resulting option shouldn't be user
selectable. It's a property of the architecture, not something a user
should be worrying about.
I also don't see why this patch needs to come here in the series. The
main refactoring in the following two patches looks to be independent.
~Andrew
|
