[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/8] build: Remove CONFIG_HAS_PDX
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Jul 2023 11:38:14 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q7TwtBQMoB/ADHaeR/9vVOecR+8XvixG9mM/INkO07M=; b=iQBwHx8i+Yq6X9joAr+LNihf8RxnAoQf5AB62Ut182bjZtdqzRWf9sO50BZcbN4jihRZisiBVWoGPb91RrS0EyMkPwuRuEFdelqcWWF5Tz41sK/rVgjimgFNK5kPmBn6ICCNUMjr0tYA4BVfRszHnUiYaTr5gVLhGbjJ0iWt06YxjCGLzQh/+QCdO7GiGXPywT3i9NY7fexrjepf8MYXit+s0/ZNYAi8TN82emPWsPbj3zx6UIwetJFQJtMiIbSbK501nXYuw7HOMPnMpMBrGZdBb4Ndu4Km26+V4yELaFnxCNGZYPITj/Lc0E2/QRRt2Zt23f0zXvAdVfR5HRSJig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UTR70kA3V7yh9k4xl79qZJzaf1EYHJJSUIA462krSkEIMXF3a/lTmHp1QLtI9zQht5Fey9Qcb6fmYEYdKSH7SPiL6TGOe72K+zJ0NYbFtLwVquq6oRxGLMWMs895x7BtBTY3ep2lrhJZ2nVKMF/piRRaCb598AnSj3pbq6T8qD9crqL1xttJWf4iRJkYEL7zCcwqP5a+LnKMGZDaNLVJOKdadTfitfEau0ifIVg1CSpw4Tv7HRiBf/itAiTm8oQvaB9JM/chenlOmvM8k0K9EwtZEyvi+TWHxDxzm9dMsJwmO1n4/x7lJaNDpFmIui8fGO1ErH1jZCmTPgANRWbaIw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- Delivery-date: Tue, 18 Jul 2023 09:38:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.07.2023 11:35, Andrew Cooper wrote:
> On 18/07/2023 10:19 am, Jan Beulich wrote:
>> On 17.07.2023 18:03, Alejandro Vallejo wrote:
>>> It's set everywhere and can't be turned off because it's presence is
>>> assumed in several parts of the codebase. This is an initial patch towards
>>> adding a more fine-grained CONFIG_HAS_PDX_COMPRESSION that can actually be
>>> disabled on systems that don't typically benefit from it.
>>>
>>> No functional change.
>>>
>>> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
>> On its own I don't think this is okay, as it's unclear whether it would
>> affect RISC-V or PPC in a negative way.
>
> Neither could compile without layering violations of PDX logic in common
> code, and neither have got that far yet.
>
> Now is an excellent time to be doing this, because it removes work for
> RISC-V/PPC...
>
>> If at all, it should only go in
>> together with the later re-introduction of a CONFIG_*. Still I question
>> whether that new CONFIG_HAS_PDX_COMPRESSION (which imo ought to be
>> CONFIG_PDX_COMPRESSION) then wouldn't better depend on the arch-selected
>> HAS_PDX, such that it wouldn't wrongly be offered to choose a value when
>> compression isn't supported in the first place.
>
> ... although I do agree that the resulting option shouldn't be user
> selectable. It's a property of the architecture, not something a user
> should be worrying about.
I disagree. Exotic x86 hardware may or may not want supporting, which
can only be determined by the build meister, as long as this is indeed
meant to become a build-time decision (rather than a runtime one; see
my response to the cover letter of this series).
Jan
|
