[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] x86: Add Kconfig option to require NX bit support
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Jul 2023 15:19:56 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LAYuyBxSmIBnmASGk99SD4iM8FTfM6u4BoEaGoa3eIc=; b=DwyGXD1Utn3w1a6WD6SC4Vy4fzMOvdyzwepwA4HuE1BvwQ7g7dzZJ1PdG6/kKLmqdD+0IWB7OIh0A8wbvU/06eAUL9WmB1mKU7SdYsbsyWROGF7c/wuwIbdoiw4buyTFGdQd/P4CvMvoadsjkPamEsZFOohxN0TCmLfI81eRKErn1uqZPkjDhad9k/Ug3PZjK+ItcrJYmoDhMNSoHoMAyPurrs2M4LbQdBmS03OGh/QAk2fYXQ9vABGrNU3uGfrIOdqSGZMmaxznjHQY7VrIq4QRf5o0Pon/UBMCML85mWevD1gMcriGtWDBXXZ5kjUbAz3IgWDxNHPqYIRZCTdA+w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HQcI0VG1PaxNQy12xkMXZfaSdCMqWAIQfzEmNNhpGjDBGW1ieT4lEARvjRQQK0c5SQ2IBQ99wY3Wl8Q/eURZf9wpYDQCtLtC8yFdjSEJXQ3bkeFzak2WmIABLpLTWeF+Dd2bbMRxpy8sVjWCIlbvirtb9lGWOE88SgyX1RGnXgqk8AqOV9vrhOnXEAA4zyxYrdGncQ3iKTK3moBDELQerafAnj3DlXfv6QpjTvwaxi3F+XEzWUG5pAFDXO1FwlSwl/Dc7N9hoOo1oQYkEuvEhxq3kseOeFnuY5Zs0uomuKqRJa2ZRkvwOWEMUJOxgjHaViOiV3qIfZd3BmSIGxIRPw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 18 Jul 2023 13:20:13 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.06.2023 14:17, Alejandro Vallejo wrote:
> --- a/xen/arch/x86/boot/head.S
> +++ b/xen/arch/x86/boot/head.S
> @@ -123,6 +123,7 @@ multiboot2_header:
> .Lbad_ldr_nih: .asciz "ERR: EFI ImageHandle is not provided by bootloader!"
> .Lbad_efi_msg: .asciz "ERR: EFI IA-32 platforms are not supported!"
> .Lbag_alg_msg: .asciz "ERR: Xen must be loaded at a 2Mb boundary!"
> +.Lno_nx_msg: .asciz "ERR: Not an NX-capable CPU!"
>
> .section .init.data, "aw", @progbits
> .align 4
> @@ -153,6 +154,11 @@ early_error: /* Here to improve the disassembly. */
> .Lnot_aligned:
> add $sym_offs(.Lbag_alg_msg), %esi
> jmp .Lget_vtb
> +#ifdef CONFIG_REQUIRE_NX
> +.Lno_nx:
> + add $sym_offs(.Lno_nx_msg), %esi
> + jmp .Lget_vtb
> +#endif
Since I'm in the process of introducing more such paths (for the x86-64-v<N>
series), I'm curious: Have you actually had success with getting any output
from this code path? I see unreadable output come through serial (provided
it's the normal com1 I/O port location where the serial port is), which
likely is because baud rate wasn't configured yet, and hence I might have
success by changing the config of the receiving side. And I see nothing at
all on the screen. While kind of expected when in graphics mode, I wonder
whether this ever worked, or whether this has simply bitrotted because of
never actually coming into play.
Jan
|
