[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/4] x86/idle: Get PC{8..10} counters for Tiger and Alder Lake
- To: Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Jul 2023 15:35:09 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SKNiIAb7UMZ/CQOhwRgB6/YTS04hMOKJYnQBe1pbbUM=; b=By2Pntlw/9ueZvVvWKmstWTvlhAAVYXSja4YjYVTUO5KFaXCkWFocY5GCHZQ4GmSKlRm/NSXy4XmxDncd2KGQ869f5X9KngBLjJ4EqCmir2hxmrZWZlcwllQyhWTmp97eP4XCe0ERZYLrELQRXdT5GkfrcHYvNfvJdv6TIuiAK7c9mfwHr3/Rj9c6Aicn+llPkk4nrBNsEg3cZvfEtwMbyUkii9rbL0IUC07mKxFRRJZbWztLcSpbiqKQnZOVL8OIsvL2sARgLep7HtJvFyPkpZ7hnfTUJ/VRHOZU4/JxAb+0hYzyJpMmDl79ShFmev13M/7fLf+i8De54Kv2BwYTA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JIJJQPwQ/yMMtlE+x2elF3274LxzNzpRasIQY0upPkIuOST0lxjgqSIcLqiauEFdUi+0jf9BRhktoashpYGMr6l0D6eMBFOs2MjhDeaFCOzzN2nTYTWXCTgJc5qyHo+4dfpyC5lVxUdswex9n7cfK8zdcVq8ZTK8vTO2HnWWWNhDP8Qwg2acPudUw+hDFKdy4ASrzb1398OOm3hPff63xkOsaSZS02YhLAHV5BSqZJ0XB7WnVSoV0l+s/DGO0iy26iyE1b8MCjTus3kQv3L9q1CL10+EBHpAl7/xwid23Bmx6nnw+9gCXwZTISN7kgIOs+cyD50oN2uMBrWSE25raw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 18 Jul 2023 13:35:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.07.2023 15:23, Simon Gaiser wrote:
> ---
> xen/arch/x86/acpi/cpu_idle.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
This lacks both S-o-b and a proper description. The latter in
particular because you ...
> --- a/xen/arch/x86/acpi/cpu_idle.c
> +++ b/xen/arch/x86/acpi/cpu_idle.c
> @@ -155,6 +155,12 @@ static void cf_check do_get_hw_residencies(void *arg)
>
> switch ( c->x86_model )
> {
> + /* Tiger Lake */
> + case 0x8C:
> + case 0x8D:
> + /* Alder Lake */
> + case 0x97:
> + case 0x9A:
> /* 4th generation Intel Core (Haswell) */
> case 0x45:
> GET_PC8_RES(hw_res->pc8);
> @@ -185,9 +191,6 @@ static void cf_check do_get_hw_residencies(void *arg)
> case 0x6C:
> case 0x7D:
> case 0x7E:
> - /* Tiger Lake */
> - case 0x8C:
> - case 0x8D:
> /* Kaby Lake */
> case 0x8E:
> case 0x9E:
... don't just add new case labels, but you actually move two. It
wants explaining whether this was outright wrong, or what else
causes the movement.
Jan
|
