[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] x86/msr: Allow hardware domain to read package C-state residency counters
- To: Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 18 Jul 2023 15:31:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Umhn/UNfEyDPEfccZQ+7Y17IMf8ChaDDd4GeUL7WtlE=; b=HR1IsWJPnhNHM/W5N/qCUeq8kv4on+kf/o1duralXcW7lY7ZYEA5OWHxWmZOzlK8F31z8dU1109NOrJAbJ2e3O8yT9b/yJa5yXSD1s0XLGUj/Jm9LgFnDBDkU6VgX3yn8o/MJLmLw9bWDYJIi6SWqpdm598aq10g4LUDm+LyTLM1vzdUoZqP7cdTkv8bKTpWFrkX4gZePmn0PApE+AITOqaiA5bJApu8+nN6CSDzqizsClq9eGf4wv6yLOrsUuPBNzdc/CdZnqkYX1MhHhu/A3HOGOh2oSwbn2vf6MpDXxu98fQD1ozranZtaA3Hrfm4Cy0WhqxyG/FTmnv/zCSoEg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h9z+AmZA1GryZeM4tmY4lNkPS2BMDWWVgWipP4xM4+biQ6g7yHyQJsRThLcFL+8Ob6HlUE6C2FRQjmOEXtvQplBLA2A3nH0tOteOKJq98ZmiDa36DS6fH9wTer4payap+2Fn3ezkqa9AU7C8RiJeUOmvI+tMb57vUV6MopcXr0b6U7xt5jUKsGUfu+lgUuZScC1n69st8BhB1PUAqrtjcYsoMDkJue+7Xn9Eu5tAggPqOpv2O+Y1eH903byh9qLm8vSuPfYKKmKpxDFzYLDp32h0eTgrgYjkodGyTvb/Iw6TxSuJbDIgVJFTD9StTaHUglxu+Y0DTgDtV9cx7velNw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 18 Jul 2023 13:31:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 18.07.2023 15:17, Simon Gaiser wrote:
> --- a/xen/arch/x86/pv/emul-priv-op.c
> +++ b/xen/arch/x86/pv/emul-priv-op.c
> @@ -965,6 +965,20 @@ static int cf_check read_msr(
> *val = 0;
> return X86EMUL_OKAY;
>
> + case MSR_PKG_C2_RESIDENCY:
> + case MSR_PKG_C3_RESIDENCY:
> + case MSR_PKG_C6_RESIDENCY:
> + case MSR_PKG_C7_RESIDENCY:
> + case MSR_PKG_C8_RESIDENCY:
> + case MSR_PKG_C9_RESIDENCY:
> + case MSR_PKG_C10_RESIDENCY:
> + if ( boot_cpu_data.x86_vendor != X86_VENDOR_INTEL )
> + break;
> + if ( is_hardware_domain(currd) )
> + goto normal;
> + *val = 0;
> + return X86EMUL_OKAY;
In addition to what Andrew said: Why would we suddenly allow these
reads to succeed for DomU-s?
Jan
|
