[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 21 Jul 2023 09:02:41 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EyCimDxyDREnBe55TyJyqlo4Ls8VeRuPawGlJiu3bBc=; b=fM8o22dhgdnpTlu4vyfpBbrmu6XQvKF+wbratX2YkhMF9GNgUMRi44tyS5E+kUojtGLaiRm6U6rGA/wh8lwmARB41uEoNFl9BK/kPBcnSKigfgPU1ng4LmvyY5Ugzjn7NyXRp7Qm0HqoZtRVq9Zh+ziId/BXPtURtIbsgrAelQ8OSIgAc4AcJQR8uu1SDKohE3n13ZTzDaJfd/eJ2AHHlI6IC4QBqvuz+EZgnt3oDMlUo/9JvaI1KFp2M/u/YHCHq3KlJZQJ8TyU6B/HeoWxuGPFgG793ggUxNPVUcGFv0LjVydt4YmQMJCuq9MIY9L628AZxlzlrseb5AzyytDgpg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E048ia2B7cRrF3kj67kW/ix7aR+pghBAUDsDzNx4bzZu5znFzZXrrbuUt46jL5jLHrWZdS2iLG/0toIfThy0nUqHYJdtJvWhfYcqMPKcjnBW4h/DkjDRZ8x8IoqSIT0O/2lA/xyYrxu0jBFodtPO2Rhql6LEF6Z8G8mkC9Mt6iKOxQ86zGSZuUWKAJ8/eoas4ju/nrUAEk09UMP6TckK19Z4jlhaeac/2Q0uSTHtwwQcauCvqwrS/FmXlujnlzi8yPopLFDG6YSQHz4FqPtDgL9QqxG8JkcTZiWSpKCcfLbqGlt5piN2t2WaAzkpAIbywivueArAOB8rmKex4FLIhA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 21 Jul 2023 09:03:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZu6nFJdPelAC9nE2wzAZF/5qPkK/D6iMAgAACsoA=
- Thread-topic: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu
Hi Jan,
> On 21 Jul 2023, at 10:52, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 21.07.2023 10:02, Bertrand Marquis wrote:
>> --- a/xen/arch/arm/tee/Kconfig
>> +++ b/xen/arch/arm/tee/Kconfig
>> @@ -1,7 +1,17 @@
>> +menu "TEE mediators"
>> + visible if UNSUPPORTED
>
> With this ...
>
>> +config TEE
>> + bool
>> + default n
>> + help
>> + This option enables generic TEE mediators support. It allows guests
>> + to access real TEE via one of TEE mediators implemented in XEN.
>> +
>> config OPTEE
>> - bool "Enable OP-TEE mediator"
>> + bool "Enable OP-TEE mediator (UNSUPPORTED)" if UNSUPPORTED
>
> ... you shouldn't need the "if" here, and ...
>
>> default n
>> - depends on TEE
>> + select TEE
>> help
>> Enable the OP-TEE mediator. It allows guests to access
>> OP-TEE running on your platform. This requires
>> @@ -13,9 +23,13 @@ config FFA
>> bool "Enable FF-A mediator support (UNSUPPORTED)" if UNSUPPORTED
>
> ... you could drop the one here. I think.
visible if is only for the GUI/ncurse display but the if is required
to make sure that a .config file cannot set CONFIG_TEE or
CONFIG_FFA if. UNSUPPORTED is not selected.
Bertrand
|
