[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Move TEE mediators in a kconfig submenu
- To: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 21 Jul 2023 12:45:47 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OAIP3lDRJAe/1FYN5CHROmmafD7SbM7hOzIbHZn6KTM=; b=kysdVPV/jE3OG9emxsxMzl6rwpBX/DI8Vfyvkgdbi+WcP/l6TIH5lnq95JgjzaggMDkIoSdHndNjO0YlIm3qAn0c3M4V7CcP67QNwzZRAAYew2iRtaU+8bHF/o5E5LcKio5bqpmUyZWTvfi83L/PILw4fXUqF8IVMKJJI8pAKINIbK6gQ+1q3RyuqhtBUZFqjlaGFOzyPN4ULJXtgO2WglRHRvTatUrS+d/CAg6ly2G2I06793b4fi4ttey48mPviXVTL8de1qRBY+pSoMw3SxJ4MiLpMY3WyJ9H68ADSaw14gTuCuliDIRWMyQS/6FmfUyg6kW03ET0ran/B6PvFA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ld08XqxJT7sM2QVDO8ykPZrz8wPKwAVS0q97AKlCxeY5EiGcU4GlVNmfajA2J9EhSlLz/aLyYdUaMBEP0cg5A8BVzm0tBFvzLNA/DUcT5eysiM15kqfBnlRbwJnXE7vH5nn78JTnEBsvO2I5uxBy+5g2kDzU8dvH62xvrDm/23nLwlM5Lf7Sh9DA1XIX5fQoV1g6cevm2dArp1yUw/aSseBZAHCDz7KqsPFcV87TOLaNG19gjhDlv20jlrx6UA5Z85rA/87/7fQWPp3QIHMmbr5rLlIBDUDYJhGLK7bllPhVPzRXsc5dPXxVrk89L8lpQWt2rPhdfnwtezgFCBmItw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jens Wiklander <jens.wiklander@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 21 Jul 2023 10:46:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.07.2023 11:02, Bertrand Marquis wrote:
>> On 21 Jul 2023, at 10:52, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 21.07.2023 10:02, Bertrand Marquis wrote:
>>> --- a/xen/arch/arm/tee/Kconfig
>>> +++ b/xen/arch/arm/tee/Kconfig
>>> @@ -1,7 +1,17 @@
>>> +menu "TEE mediators"
>>> + visible if UNSUPPORTED
>>
>> With this ...
>>
>>> +config TEE
>>> + bool
>>> + default n
>>> + help
>>> + This option enables generic TEE mediators support. It allows guests
>>> + to access real TEE via one of TEE mediators implemented in XEN.
>>> +
>>> config OPTEE
>>> - bool "Enable OP-TEE mediator"
>>> + bool "Enable OP-TEE mediator (UNSUPPORTED)" if UNSUPPORTED
>>
>> ... you shouldn't need the "if" here, and ...
>>
>>> default n
>>> - depends on TEE
>>> + select TEE
>>> help
>>> Enable the OP-TEE mediator. It allows guests to access
>>> OP-TEE running on your platform. This requires
>>> @@ -13,9 +23,13 @@ config FFA
>>> bool "Enable FF-A mediator support (UNSUPPORTED)" if UNSUPPORTED
>>
>> ... you could drop the one here. I think.
>
> visible if is only for the GUI/ncurse display but the if is required
> to make sure that a .config file cannot set CONFIG_TEE or
> CONFIG_FFA if. UNSUPPORTED is not selected.
Is what you describe "depends on"? "if" controls merely prompt
visibility aiui.
Jan
|
