[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 05/13] vpci/header: implement guest BAR register handlers
- To: Rahul Singh <Rahul.Singh@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 21 Jul 2023 12:50:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Ntcxhg/KtwPYaAGDIN2bQOBKdO4oDmjQx2D7ckifUM=; b=nViarJxg90pbBd9JcvvgcAXe5ZkggL3NcZj6xpAcLNeU83erMepdkltgAjTu5DIVujvguXgJo5IuqSCLLs9hp/j71Dn8h8vd9s4gAGcvwKSTydg3lTNkrmBF3kJaKiKIIGStV6qcWxbddVq62hos7dpBbiMA9GKkV4apcoV03UmdNXnet6E8pXrBc7YlNBlEAo7egX1l3+PRdCRBDSeUCqJ7d05iorxp+rqu9CxxFK0RHeiWb4YwAK1BWfxqEZ/xjwXX09c+bexROqlLuVqiHKo+sRo1VHuHEOenjKPQ5kRM0iQX8/W4ccZ3JPK9fbn/e8nX3RlOyOeu9+5tLALFIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iX2DCCcDvmngJuaX+C9Eo0nfGRhLOxnGpzTMC/6JdC6FfdJKDwI/RA/kR9hvjFgQQgEi1GMf66qxqXAJN58BD1thCnu3rj+tWjAKhLGlZeYsIlNOm8v9285WNAhix0FNR04IzjJBPuvCuK7fOCfOs83KGNCMHFxG8P+T1XTcb+9rny8RhpU1u+NB/MNSpk/dMSkXJ1I3JmXdo1ytXJJ2/K343zlFNvQXbUhacnhLAhRmr4DZOMnA7k9YLFquE1FwzLbKV9TU1QUYe33vBRTLCsXfXHl+I0JjgtR24xYaQNqloAvxl1h2EHJjiR9M/SMhSeVXO4IRuIMJJrGpAElqsQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 21 Jul 2023 10:50:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.07.2023 12:36, Rahul Singh wrote:
>> On 20 Jul 2023, at 1:32 am, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
>> wrote:
>> @@ -599,34 +681,50 @@ static int cf_check init_bars(struct pci_dev *pdev)
>> bars[i].size = size;
>> bars[i].prefetchable = val & PCI_BASE_ADDRESS_MEM_PREFETCH;
>
> I think there is a need to set the BAR mem type and prefetchable bit to the
> guest_reg also to avoid mismatch when Guest kernel initially read the BAR’s.
Perhaps more generally: Shouldn't r/o bits be handed through in almost
all cases?
Jan
|
