[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 2/3] xen/arm: irq: address violations of MISRA C: 2012 Rules 8.2 and 8.3
- To: Federico Serafini <federico.serafini@xxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 25 Jul 2023 09:09:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4LcsK9H3U5j/Fcjth15gu3w+D5a5BgpjUtmjawQXrog=; b=oAyL6IKAutQxtI8eIs0SYl4qwlP5oTMUPHfVT3Bke+LINJT8Zlfk2llGriYF+XPvDEWw6iLZrAipBzVWSwzIrO0g70dbTuDEk5tl+LeU7DeFRfBkSgfqPiUtHA4h79wtpvGMtLYU6h5LGTzcF1iz88Wjq3kk0ZNxHSj2ks7Mfv95uzYnl2Ub2V9VOrWCdC4A7uREVk3+TavJwm9tmHmrZGJa19bsJpMvlXD11BEjw7H5N+xrt6HXAQYmTCaBUoHsa1n957FnGsSjwBv3EHumPfVH8o24ixS+iUGb+XJQyjoPjQWzd5U9VzI0k/TV3PTPuStuaUHyvyHAqGUvoXBA3w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e74A7WlMK4qafJbbXTzAe2iWm/C3yo3RS647JdM4+1mGMYyRlWsgCdw1jcxLX9v4Dt/8H+Y0TKL7nynXzRNOMOlN8BiICCDp9oxt3bVhQnHWcdCD62ZgiccjCjL4sboEjvZ9K2O5RQpqRxsAPB1raz7COaNKP4D5SeXnsfHErcg0Z2dwskckn2zfa3r8fF+LmaT+sOw9rY8XvQsj6HBsSpmrx94JaG07JFYve3J1qVZ7YxHDDQ52zl5UXAGuedSpNRN7Lwtf31aqQ586QGlSOuymxtf+FQbPLBPQ7JLGISMqN35BAZmigRJuD/CWO8/DlA5/14SXFFdeeo6UGUj7yA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 25 Jul 2023 07:09:35 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24.07.2023 19:50, Federico Serafini wrote:
> @@ -182,7 +182,8 @@ void irq_set_affinity(struct irq_desc *desc, const
> cpumask_t *cpu_mask)
> }
>
> int request_irq(unsigned int irq, unsigned int irqflags,
> - void (*handler)(int, void *, struct cpu_user_regs *),
> + void (*handler)(int irq, void *dev_id,
> + struct cpu_user_regs *regs),
> const char *devname, void *dev_id)
> {
Before we accept patches, don't we need to first settle on whether to
apply the rule(s) also to function type declarations (and not just
ordinary prototypes)?
Jan
|
