[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 3/3] x86/irq: address violations of MISRA C:2012 Rules 8.2 and 8.3
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Federico Serafini <federico.serafini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 25 Jul 2023 09:13:32 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3n4JaB/SB3ZqFC5yerfJWn8FgMLSUAYKEJdFfj6eUuc=; b=O+IQQQMPm1G8b9qboJHbzZC0J363K0nz8PY8TPUoM1jNIAaiW24e2YsTUWrAM8CQd4wBgu7xXmJhenaNcINTBFZ4cVFDRTXB+Hw19NpC2/ydmpv3LEgJJDrfv+6T5H1OC+fXLQVBgnPbddab4fhDUHk5zaAP3zaInYW16MWeT9X9ER2CYPAwMZiqhjuPBlVHDeeymwTCn3LrYm7xAbawWijYCuXhDqLkeHZCc82VPbNspIUixGa8WdtYfIk5W7wW4HU7S2/n/mwJGjndoMOo0WRW6POQc4Osi0iAAk8HMwJNuIIecwxoPtlonIGpPZ+73Mm+66AWAApMvxXBOwBx5w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C0uzrNUglJzCCu4cBi2r3oeNoksPNmfxNJcUpUjhL3rlcmG1vKeMhAG1dQGaBwACLqG6K/K1e7Gfb567PfgsvYEl9mETiKuUqFVI0rLnNGmBtfPmHn1FGwlpJ1DdYgOv9VtAosQex23jneBaM8H/jRJbBCHpbb1KSUuPE8uMVmdZ8vtoDsLBotJ3cJ6rVniC2j+MeNrHXhMnETScRKC8eFKsBSqjZfW9OaOTTY/wIbJnh7+VMbAzWPJVhXnus/0r6laHVIxwamMbcghVaSJko0Pen58FHdiZbSmDuwm3u9Otk1i+Nv7xJvp/nanYj+O2GCW0g1CqkBHvaGhle+p79Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 25 Jul 2023 07:13:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.07.2023 01:08, Stefano Stabellini wrote:
> On Mon, 24 Jul 2023, Federico Serafini wrote:
>> @@ -893,10 +893,10 @@ void irq_set_affinity(struct irq_desc *desc, const
>> cpumask_t *mask)
>> desc->status |= IRQ_MOVE_PENDING;
>> }
>>
>> -void pirq_set_affinity(struct domain *d, int pirq, const cpumask_t *mask)
>> +void pirq_set_affinity(struct domain *d, int irq, const cpumask_t *mask)
>
> I welcome feedback from the other maintainers on this but I would keep
> the original "pirq" parameter name here...
+2
We absolutely should not further increase the misnaming. Instead the goal
needs to be to uniformly use pirq when pIRQ (used in interfacing with
guests) is meant, and irq when a (Xen internal) IRQ is meant. Sadly this
isn't helped by Arm not knowing the concept of pIRQ (see "[PATCH v2 0/2]
new CONFIG_HAS_PIRQ and extra_guest_irqs adjustment").
Jan
|
