[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2] xen/spinlock: mechanically rename parameter name 'debug'
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 26 Jul 2023 07:45:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bfTJgB1Z47UjsQD6hvXl+p7JOl1JmNINLAZ7kgUbkUY=; b=O+DNvludD8Kyes25c/6R8+7P2gLmFktVInzZZR2mwvTOgav1U4br2ItQnPgzd39OsKiXPvwTwLvGc+MGioTXGUQgFIH73aXGlXXSLmvm1Hwbnz70Ak99EQcn/0C69iGzl0fgIE29phwKVn4mFh8OGNBcVrSRr+qBnG3yUn6RKBbdZdw8W9PYtNpOnAB/+n3hrGKR8JJrk0nANNOPPRJdVCeFhiBJllpUho415X8dqr4XcuRDvp4UtueYeQPaDshw2lbAOth/l/Ur4PsuTkxCUG4hAF8dSxy7MT6TM00SoRutVmZ0DesqA7h0TNFsw3yXBu5a6NnQ6uqPjz13UqvAvw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XRX15/tuN08dF3JzQz0ehevupaeLcvzbnDE/qKSjanLQQX0zDCqjG9L1geZYfZUDWUW3UtOX7NhyHQeGQa+xbem8atkvyOfjou8X0cDITNnKKciaRIECiF5adzeAIB1xfTnBKNrrCJW8jGnFPC7FxAoniXnnsimePn9lS/Y0n2YoMa86H695NdxmmSy+Quspb5eY7E5eXJ/ncOSnyJwig7o/Gipd0vlHoLKAvLNlBuTTLO4dC/3hlT2rHDAdpWO5jhYn/DYD9kecBMmvqxjArRi5AguuSYO5+kjz8yhhaKQtqkMN3ZoqUkC0z8ZhyZFD6E02dk21M0vhvCVmgZKXGQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 26 Jul 2023 05:45:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.07.2023 22:28, Nicola Vetrini wrote:
>
>
> On 25/07/23 21:37, Stefano Stabellini wrote:
>> On Tue, 25 Jul 2023, Jan Beulich wrote:
>>> On 25.07.2023 11:17, Nicola Vetrini wrote:
>>>> Rule 5.3 has the following headline:
>>>> "An identifier declared in an inner scope shall not hide an
>>>> identifier declared in an outer scope"
>>>>
>>>> To avoid any confusion resulting from the parameter 'debug'
>>>> hiding the homonymous function declared at
>>>> 'xen/arch/x86/include/asm/processor.h:428'
>>>> the rename of parameters s/debug/lkdbg/ is performed.
>>>>
>>>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>>>> ---
>>>> Changes in v2:
>>>> - s/dbg/lkdbg/
>>>
>>> But only in some of the cases. E.g. ...
>>>
>>>> -static void check_barrier(union lock_debug *debug)
>>>> +static void check_barrier(union lock_debug *dbg)
>>>
>>> ... not here (there are a few more).
>>
>> I agree with Jan: these are all union lock_debug parameters, so it would
>> make sense to me to use lkdbg everywhere in this patch.
>
> Yes, indeed, that's unintentional. Can this be done on commit or should
> I send a v3?
This wants to be a v3, but I'd suggest to wait a little with this until
we've decided whether to go the alternative route and rename the entry
point symbol that's colliding here. I would prefer this in general, but
even more so if sooner or later we'd rename most of them anyway.
Jan
|
