[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3] xen/spinlock: mechanically rename parameter name 'debug'
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 26 Jul 2023 08:34:05 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wPAda3NxuYrN5eM+4qGSUW0FwYcB+s3cz+gelEC9PeI=; b=evU0ABe8m0fpuZx9u0vkkEXlcFb0jZVyD5RKPviJu8PAkJ4KCa8LlwswmwW8136d0TdlYdhx+vE/BESnMK57Jm3AD8trjKJp0DZUYsJuznuvNFv87AUaT1DR3C5q6za3hzdtzYw5eBxhyz90BMQxir9rg5meHI/KVFGfFGZ1rN2Pgf/im8q0Q0HpKA0LnBJywL6i30C0XdEWefMQNRQJuOvK/04IEiodAxqjnP00TuEDytss0ruqK5/VAC3WXYal81kYyhHuYda1g/5dZMtO+/lDoSSzQ7P0AQKfcmzC1oDyXaABfG3OMN+Fm5nd+0iT0slAEmsDiRIAzgPH3WBIgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XuGS1WEZ8znwPZES/QRh9M+RcFG2blrUX+NRuRLPdc2jKWDKmmCVNfZuLfw0JZYiEXXitwza/NtSYJgsAiVIpJz1oiwrBuFt2aL6A5gYHFN0Fcdrzose8f0aTq5sDBcFBd5Tumxrtd7onmeCqyfcrR+F13r6pI3PV1ikpInGu1AdAxcKxc9XOxmqnX0dJZDP2cwlV/nKzJ9kgQQwWnlWcG+7xVdA2/gqQjohRnZUR86c5fHGshmEWXMmw6OVNaCFpdf6c+lweGBgeamdTcSAQnBUD53pI7N/HueHz+YYExKZbe74mUXqikYgmCA3+g9z5JMESWZNjoYOR1nuBkiuWw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 26 Jul 2023 06:34:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.07.2023 22:45, Nicola Vetrini wrote:
> Rule 5.3 has the following headline:
> "An identifier declared in an inner scope shall not hide an
> identifier declared in an outer scope"
>
> To avoid any confusion resulting from the parameter 'debug'
> hiding the homonymous function declared at
> 'xen/arch/x86/include/asm/processor.h:428'
> the rename of parameters s/debug/lkdbg/ is performed.
>
> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> ---
> Changes in v2:
> - s/dbg/lkdbg/
> Changes in v3:
> - Added missing renames for consistency
Hmm, you asked whether to send v3, but then you didn't wait for an
answer. So to repeat what I said there: I'd prefer if we could first
settle whether to rename the conflicting x86 symbol.
Jan
|
