Re: [XEN PATCH v3] xen/spinlock: mechanically rename parameter name 'debug'

[Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>]

On 26/07/23 08:34, Jan Beulich wrote:
> On 25.07.2023 22:45, Nicola Vetrini wrote:
> > Rule 5.3 has the following headline:
> > "An identifier declared in an inner scope shall not hide an
> > identifier declared in an outer scope"
> >
> > To avoid any confusion resulting from the parameter 'debug'
> > hiding the homonymous function declared at
> > 'xen/arch/x86/include/asm/processor.h:428'
> > the rename of parameters s/debug/lkdbg/ is performed.
> >
> > Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
> > ---
> > Changes in v2:
> > - s/dbg/lkdbg/
> > Changes in v3:
> > - Added missing renames for consistency
> Hmm, you asked whether to send v3, but then you didn't wait for an
> answer. So to repeat what I said there: I'd prefer if we could first
> settle whether to rename the conflicting x86 symbol.
Stefano replied asking for a v3 [1] before I had a chance to read your 
message this morning.
[1] 
https://lore.kernel.org/xen-devel/0a7742a3-7f94-de37-cab7-ef54ffcef8ac@xxxxxxxx/T/#m14b4eebd936e3b349491a1b9f46a17a5d9bb9c30
--
Nicola Vetrini, BSc
Software Engineer, BUGSENG srl (https://bugseng.com)