[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3] xen/spinlock: mechanically rename parameter name 'debug'
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 26 Jul 2023 08:47:42 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cv/S8H7VBVCXw65UxxrbNttfmXrKo98kPc4TNsom7Ns=; b=JKnFP6sVwefppiMuVGrp5bGprP5/q+gkI9rz0YfIDdCOTxt1dLk6WHFxazR0OUMgsoUdG+n9RkcZJU7D1MJtpblOtNpjrtWt0ezErwhjypYG6XrCdZ6erpEeVbWL3E56Q3PqR3CQ+ZcA/mzEp5QB8qFcBr7DsRGbCvWla7ChIk/CDiPJhQdaKWsu9vECXRRmy6mBw8XRWwKdbxTPK1g4dqPad7l7/7LmVWXKRfPpIpoDCeAlYxQcRKANXEkZftVVvWuEy3HtD8jINjZR5ADscrIHjyvy1BMeNOkcZQ7fG+UUZrFIlOgYPTtClqHLcs23htK1Q2zhGDUn0YHNx6hf2Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hGwU1C5EO+btJtuGOQd4koBobG9bWW+iPIcxeTPJjYCR05SrOv1Tx7pB2d8p/xXEw8EXFmopo+mYg4OT3RvfHqV+pZcSY8oLJa68tpx2jDTwCMQlEq16QOp9a2S93bh2ICMaaelz6a2S7QWygKLr99+kzeM4DLaVhxsLjvlGb6SVy5SHxwFaez4GA/L3cmdh/6QMa5pu9JX0GTWJumLQbBxSMPfcJNjiuWGLKckDjGXkUWgM5HAIv+pMP/08kgoW3WOsy6f2mknRi420Pw5LvTIBnK+xK6dU7d8lc/R+XGRfXH6IZurfPZ31xLxJ7yzUHIf+X459bzYEyUia9RhwXw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 26 Jul 2023 06:48:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.07.2023 08:42, Nicola Vetrini wrote:
> On 26/07/23 08:34, Jan Beulich wrote:
>> On 25.07.2023 22:45, Nicola Vetrini wrote:
>>> Rule 5.3 has the following headline:
>>> "An identifier declared in an inner scope shall not hide an
>>> identifier declared in an outer scope"
>>>
>>> To avoid any confusion resulting from the parameter 'debug'
>>> hiding the homonymous function declared at
>>> 'xen/arch/x86/include/asm/processor.h:428'
>>> the rename of parameters s/debug/lkdbg/ is performed.
>>>
>>> Signed-off-by: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
>>> ---
>>> Changes in v2:
>>> - s/dbg/lkdbg/
>>> Changes in v3:
>>> - Added missing renames for consistency
>>
>> Hmm, you asked whether to send v3, but then you didn't wait for an
>> answer. So to repeat what I said there: I'd prefer if we could first
>> settle whether to rename the conflicting x86 symbol.
>>
>
> Stefano replied asking for a v3 [1] before I had a chance to read your
> message this morning.
Right, sorry, I spotted his reply only after seeing the v3.
Jan
|
