[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxl: Add missing libxl__virtio_devtype to device_type_tbl array
- To: Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 26 Jul 2023 16:50:38 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=t/+7aOrL/bJ/KQd2wEwAofJ2XrcTnus/CzmcUnnAoSM=; b=FihqdE48+Wcej6OUWVNkxpDDjTse906BhG/YNMzQmbqHCPKG59eK8HkmxGgt+XD2EJioLkm676KOLYIvYR/ttCN/S58nfMR4a8LYMOkgsJo7oYEH+vK2SjzBthjwf6BF0Y8qGeKOUWkKwAjVKew6iGU4vnF8CUCKDuMI6joJdhCvvEFvz5SilTX6gViJwPAYQQKu4XdhOW4QfJe7BKGRuR/zWSPSauYw0Us8onCGxRCx/CfeRPDwkOIOqgsr7jfQ9g1CcjFn/PpC3/CJzLn/Cx279G4bSgqjewZ8oSwY79EdZjUM2JpM1KuBT29wJ68XA00ngqx5A4EvrMM0b4zMKQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B04bfbLeqaYgrpUXXXu0/gPA4H4iE6PipoPEsjVZtipi2OQ21eC9qUcPWZgFkzNIEAZo/zMYbg+fOrNz+4AIanVA3x600GxNb68HvM31Gzy9BmvWJk+xsaU72WgmmP4mLuuURdGnUOGNh0kPzjHL71Dpukyj+VzxQY1kT96dUoyP+9gcWHKMRC4VKqaJQqJiVq15EJkNQiiKJmVDCRUxhx8oOJOL++fYNcsjbDOtA/hTXwF7XpjM5Rv+HYjMXOA2Gg1yOZ94YOVvcR9/Xxp886y61UeN1ICW71L5vSRLA3fThgUg9aIcBGrNf4Cuq0iqe6/y/eJtT/NdrM2p9mlw+Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Viresh Kumar <viresh.kumar@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 26 Jul 2023 14:51:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.07.2023 16:14, Oleksandr Tyshchenko wrote:
> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>
> Without it being present it won't be possible to use some
> libxl__device_type's callbacks for virtio devices as the common code
> can only invoke these callbacks (by dereferencing a pointer) for valid
> libxl__device_type's elements when iterating over device_type_tbl[].
>
> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
> ---
> tools/libs/light/libxl_create.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c
> index 393c535579..c91059d713 100644
> --- a/tools/libs/light/libxl_create.c
> +++ b/tools/libs/light/libxl_create.c
> @@ -1887,6 +1887,7 @@ const libxl__device_type *device_type_tbl[] = {
> &libxl__dtdev_devtype,
> &libxl__vdispl_devtype,
> &libxl__vsnd_devtype,
> + &libxl__virtio_devtype,
> NULL
> };
>From description and nature of the change this looks like a Fixes:
tag would be warranted.
Jan
|
