[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] libxl: Add missing libxl__virtio_devtype to device_type_tbl array
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>
- Date: Wed, 26 Jul 2023 15:13:33 +0000
- Accept-language: en-US, ru-RU
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rr+eS77ylG4iI+Pt6PsZZob+13jF2qBqZatQSXE7LwU=; b=KccT8ovswkvFfJ5/IaE+Hj2uxVVWHnj01tnz064Cb+ALYvasK5bInYVzI+QmecVFI/7rrQ/lw8FTwKRBRv/MWJSq1WjNpPk8OmA3tzubZ/v/ScfV0prpcRTSsCN90vlBnXyfs7aMm4jpFx5Sw1T7FdGcgf70UVrdDpH7lehWuUxL5g9Mua4vmQgpyZc1HCNCWJVWyQ4fW7RDBAyMK5MT+qruAqO/AgHj2GwcZG//1QhG/PvxNrVjA3+npjFYH/jL+4lDaMllNz9UAd2VZTCnkCS31lSXUEQJ6Sw1v0SK3JFUjJvfPODsrGQf3mPFdY4j9RbgVVH8skRmywxdmCioUw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l718wescjBx9Z++SBpwhwE/pw06CbBRMk5b6woE5Lt/N/woCvLG85e8OiOcx3ejxdmNMLXEoFOkFFBkSMQrxVMBKNQkWnMLtWaMjGCjbHM/hzqWBVYwUJsgdZblpLpRqmSpj8txiHi0oDQSnvvzsnOVZYpjbBsSoCW1mPcegHqm9Q16BdPSPbU5uJy3PZMkA75unl9acgkpNlBOad37+ttI5gPkAEadc4NqlchhzekhlyzPNAKfHOrViQTYMKHaLskIqWkT+j6kWfCdjMu8QVWaBPmukcduzmlyfjVVaovT5/I82srYTHinfQf3FIk0Oae0Vl1hIoKEkqASNJy3J6A==
- Cc: Wei Liu <wl@xxxxxxx>, Oleksandr Tyshchenko <olekstysh@xxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Viresh Kumar <viresh.kumar@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 26 Jul 2023 15:13:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZv8uYlQiykVHkhkC1aQss9HQu9q/MIX0AgAAGYQA=
- Thread-topic: [PATCH] libxl: Add missing libxl__virtio_devtype to device_type_tbl array
On 26.07.23 17:50, Jan Beulich wrote:
Hello Jan
> On 26.07.2023 16:14, Oleksandr Tyshchenko wrote:
>> From: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>>
>> Without it being present it won't be possible to use some
>> libxl__device_type's callbacks for virtio devices as the common code
>> can only invoke these callbacks (by dereferencing a pointer) for valid
>> libxl__device_type's elements when iterating over device_type_tbl[].
>>
>> Signed-off-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>
>> ---
>> tools/libs/light/libxl_create.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/libs/light/libxl_create.c
>> b/tools/libs/light/libxl_create.c
>> index 393c535579..c91059d713 100644
>> --- a/tools/libs/light/libxl_create.c
>> +++ b/tools/libs/light/libxl_create.c
>> @@ -1887,6 +1887,7 @@ const libxl__device_type *device_type_tbl[] = {
>> &libxl__dtdev_devtype,
>> &libxl__vdispl_devtype,
>> &libxl__vsnd_devtype,
>> + &libxl__virtio_devtype,
>> NULL
>> };
>
> From description and nature of the change this looks like a Fixes:
> tag would be warranted.
Looks like, yes. Thanks.
I guess, this should point to the commit that introduced
libxl__virtio_devtype
Fixes: 43ba5202e2ee ('libxl: add support for generic virtio device')
>
> Jan
|
