[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 28 Jul 2023 17:36:23 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c0zzenPVbxs7TV04LIa7VSnq8RdNL+ZTFwqIy8IIH6k=; b=OGwYBc6uifpCN9LnzmIc5NXBpQYkETVBqANetYCKAj/8APZV+9pBqLYyUvbafxfP63nd+cz7tSEEHACKX/kwlAY8JDEX2iEryLp8QoLKgRDiwUS5eYqQ2ZebY63uC3eJKLYHBetG2mzfhGMyHF+IuCEqk9ZknPxq1gSxAhnpMKxc043SNjaVyMHlv4n/dOwL5T33VpXeh1z0Ef8O0oeh6VVFmLKduyxx+cs0Hbqkb1BhkM3uNuzgpRUNleIpdFqz7C7ii9hnLjxlG19moUDqe94zQwwuM8TfOfjMKrlRqd3iw2qay741ooiaAxp8HZnbtJSNJTu9O60E+Z5Z0EtkpQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZRrtsSnmkGg8xt6l6LhnH6dBvLxjq/JG0i2zqjzl9CewDhshMmwl3y29PCn+uW9oo3k4B8MLhDFHpeef9JiOS1quuYxqjiBwKqhxXI1J5/dgIB+AMAv7g4hMhG09K/x4rypgZN+CVwGL4483rmWx06+S065abC6w5fv50ndYhAzRFgo+KObkLJljXfOGwteWqlkAgaM/hUAzYl9Yuw1KFyxW2iPKuGdnz2gSdnDAo+JIoqJIkkFsm6UHYaHOhL3t7IMji0Jjh3q8QBeMwZakKhiDblLZOshDEI7+QTFPuyMnt2gBujv1UXGI3aWbvRH8n9wppAaca3cdy4YTG7njpw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 28 Jul 2023 16:36:47 +0000
- Ironport-data: A9a23:nQ2MManvott6oAeKoW4r+hXo5gwnJ0RdPkR7XQ2eYbSJt1+Wr1Gzt xJJCDzSM6qNajOhe90lb97k8U0EupLRy9NrG1FlqHpkESMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgU5g+GzRH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 ecDGA8mdCvbvMy756zgSMlKieo/Kca+aevzulk4pd3YJdAPZMmbBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3ieC8WDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTeLmqaEz3AD7Kmo7JBg9VH3qr9uAsE+PSdFta HE7wywxov1nnKCsZpynN/Gim1aNuhMeUtxcCep89giJzqfW5C6SAm8ZQnhKb9lOnN87Q3km2 0GEm/vtBCdzq/uFRHSF7LCWoDiufy8PIgcqfjQYRAEI593ipoAbjR/VSNtnVqmvgbXdGyz0w j2MhDgzgfMUl8Fj/6+250zdijSg4J3AVBco5x7/V3igqAh+YeaNWYus7lTK6OdaG6yQRFKBo XssltCX6aYFCpTlvC6HTfgJHbqpz+2YKzCaillqd7E+8xy99njleppfiAySP29sO8cAPDPsP knavFoJ4IcJZSP7K6hqf4i2FsImi7D6EsjoXezVadwIZYVtcAiA/2dlYkv4M33RrXXAWJoXY f+zGftAx15AYUi75FJan9sg7II=
- Ironport-hdrordr: A9a23:J+VIkqvrz5+nfWI5TBNJbKqT7skCM4Mji2hC6mlwRA09TyX4rb HaoB1/73SbtN9/YhEdcK+7SdW9qB/nlKKdgrNhTotKIjOW2ldARbsKheHfKlbbak7DH4BmpM Jdm6MXMqyOMbAT5/yX3OHSeexO/DFJmprEuc7ui05ICSVWQ+VY6QF9YzzrYHGfhmN9dOQE/F 733Ls2m9JkE05nH/hTfUN1O9TrlpnwjZf7ZhxDLwc/gTP+9A+A2frBCh2F2RVbeC9OxLpKyx m5ryXJop+7tu29yFv632vehq4m/+fJ+594HcmRjcpQDCvqhh3AXvUGZ5Sy+Aotpf2p6hIRsP SkmWZZA+1Dr0nJe32zo1/W1xL+3C0I43vvoGXo+kfLkIjCXTcnDMgEuo5DaBve7CMbzatB7J 4=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/07/2023 8:59 am, Alejandro Vallejo wrote:
> Adds a new compile-time flag to allow disabling pdx compression and
> compiles out compression-related code/data. It also shorts the pdx<->pfn
> conversion macros and creates stubs for masking fucntions.
>
> While at it, removes the old arch-defined CONFIG_HAS_PDX flag, as it was
> not removable in practice.
>
> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
> ---
> v2:
> * Merged v1/patch2: Removal of CONFIG_HAS_PDX here (Jan)
This series is now looking fine, except for the Kconfig aspect.
This is not something any user or developer should ever be queried
about. The feedback on the documentation patches alone show that it's
not understood well by the maintainers, even if the principle is accepted.
There is never any reason to have this active on x86. Indeed, Julien's
quick metric shows how much performance we waste by having it enabled.
This patch ought to just rename HAS_PDX to PDX, and keep it selected by
the subset of architectures that still want it.
~Andrew
|
