[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/5] pdx: Add CONFIG_HAS_PDX_COMPRESSION as a common Kconfig option
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 28 Jul 2023 17:58:05 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sG2xeXvda2IyP8areTnFv8MwtRgz9w+sOfGHrPK3V/4=; b=CmpSA+LojpMwoiCkz5juAFw66Fo7u/yL4R9Gx6PDBR/kjwkCozOLKV7d3BjXg91H8mfKi16re+nlDzreSbpq5mKNJuZ4t7say66/6ZfqCnMyC2GDiF0Uxh7U7lmH60fQ7C795bP1ctvGV8Ai1rp+6NcyyGzShU9R8nP/b5Sw4iF+nsoCX+dB1QTr6SakZ5x47X8GJyYM/cHZeiyvMheJFB/ojPpbP1CF+GhBSykd7HwjXMettJnGv5biVdlHmvqTIohwAT/QPTm/v24L6tRujVFHkEFtlhJYOa8GZlqngGybjaIp9oApJLhbLLXXQkeHf7GLpGUAfdhw0dhzqZvZYQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CxWL0zZbynMXFLCVa4WN1eXR6aJM2VLzjIEuL3DFRetwifsXXnDIN4HhYAQxhQ5fcPPKurCy/jzQvSb2abMBVQCTc7CpPOZy30f2f2j3SAa2SDLKR08luv2kXyrWj4RSsJZit/hn55eiebqv/xbZT4kmQlD/yE+MuGfeeVZLSs6SliMM0z6oULw84YUU5omFV4xVCdP4ffYSNQ+A4tHvr5SudenxmNQAb2jUFX2mfkFwbaehmDMtyyQ+IhaQGWFH4oSLx86NrDeOOqLozmNp4KszPDnNkyIuMKqBdQIgr/QuD5Nacac4mxsD7o3RaNzTkHQQ9N98kW6fA8x1gMq6mA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 28 Jul 2023 16:58:30 +0000
- Ironport-data: A9a23:yuf6v6uliFB5ShHDqVwgCSd6ZOfnVPBfMUV32f8akzHdYApBsoF/q tZmKTqEO/uONGL9fdxwOYW18xsPuMfRmtExTAJvrHthQy4W+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5ACExyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwGjkBUjSixNyP76+1RuJHvpguFsXQBdZK0p1g5Wmx4fcOZ7nmGv+Pz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60b4C9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOThqa4z3gDMmwT/DjUzZV2euuuS1HLjRslyM mAvuSkVj5gboRnDot7VGkfQTGS/lhcYVthZFeEg70eTw67Q7gSeLmMASSNNLtchsaceVTEsk 1OEgd7tLThuq6GOD2KQ8K+OqjG/MjRTKnUNDQcfVhcM6dTnpIA1jzrMQ8xlHarzicf6cRny3 jSLoS4Wl7gVy8kR2M2T913dnyiloJSPSwcv/xjWRUqs9AY/b4mgD6SW7lzc4edFPZyuZFCLt 3gZmOCT9OkLS5qKkUSlQu8AAbWo7PatKyDHjBhkGJxJ3yup026ue8ZX+j4WGatyGsMNeDusa kmDvwpUvcVXJCHzMvUxZJ+tAcM3y6SmDc7iSv3fcttJZN52aROD+yZtI0WX2ggBjXQRrE32A r/DGe7EMJrQIf0PIOaeLwvF7YIW+w==
- Ironport-hdrordr: A9a23:XAi8Pq73sWqwjMPhTwPXwMzXdLJyesId70hD6qkmc20wTiX4ra CTdZsgviMc5Ax6ZJhCo7G90cu7Lk80rqQFhLX5VI3KNDUO3lHEEGgI1+XfKlPbdxEXWYRmpM BdmwQVMqySMbDa5/yKgjWFLw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/07/2023 5:36 pm, Andrew Cooper wrote:
> On 28/07/2023 8:59 am, Alejandro Vallejo wrote:
>> Adds a new compile-time flag to allow disabling pdx compression and
>> compiles out compression-related code/data. It also shorts the pdx<->pfn
>> conversion macros and creates stubs for masking fucntions.
>>
>> While at it, removes the old arch-defined CONFIG_HAS_PDX flag, as it was
>> not removable in practice.
>>
>> Signed-off-by: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
>> ---
>> v2:
>> * Merged v1/patch2: Removal of CONFIG_HAS_PDX here (Jan)
> This series is now looking fine, except for the Kconfig aspect.
>
> This is not something any user or developer should ever be queried
> about. The feedback on the documentation patches alone show that it's
> not understood well by the maintainers, even if the principle is accepted.
>
> There is never any reason to have this active on x86. Indeed, Julien's
> quick metric shows how much performance we waste by having it enabled.
Further to this, bloat-o-meter says net -30k of code and there are
plenty of fastpaths getting a several cacheline reduction from this.
~Andrew
|
