[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2] x86/hpet: Disable legacy replacement mode after IRQ test
- To: Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 31 Jul 2023 16:11:34 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RNA3P3Y2g7sHUu5TisRCN8jMhK4/h6k+Ws8eNzjDEnM=; b=Xyn4mJmEcY3dAfRdTJHE+IWagedAtt5idEMbjUWTzuHolzEQf7MyXtNDQDDPoqylaOI6Lk6QaZ1nBeMOuOjs+l7hguCp3EWrhJ2Jre5EA5efNNDoA+Es17Rp6g5rtzDCAIUSo9ydzDVOFgI8l88HKxVICErrRoiHJgDTfTnbqLTIG+Z9wRR8qxk7R6aY3npzY3HvMjLmerHHI+/ZO7fkoU8tqmt1WgVqDfT93NJLpPe3PZoGunV4KUCqjLNxPRAsVl+h8jaZaDcKMAbmmyRRMhAnaWH0eUEwQ2lPBjOnSAzu29L0Mzd/lvn38dXrh+g2ISEi8Dmiw4f6ss8EeeQYcg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hej9dmuLPp71GMTVEInNFFpijvd4dGoyTsfks5mbj18HEo1vIfkYLFtcw6HY51Er176ow7GridTL9O8KeMMi0kXCuRtApaRuIQy+Ihi39VsGl8PGMvb5U25ZkeGVtvdWFkOmTtl3v9PqzzGv7lTaE5xcFMPrc5maakYwHF3/efqkx3BpoS+S82DVLWg/+1kSxT4e2tcokFl4POo6etvNOGxqvvFjU4U3jTrLMW9/V0H/92/Q29sGw+xCDgZbCCjnBzQL1hooOrfvuCrNwSYP/ITeRPtR4v5VFJ/NfYlU26fJq/mQ5Jg45kZhoy4YIXjTQYUxqcp1f8xSnbnXlRFRWA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 31 Jul 2023 14:11:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 31.07.2023 12:32, Simon Gaiser wrote:
> --- a/xen/arch/x86/io_apic.c
> +++ b/xen/arch/x86/io_apic.c
> @@ -1967,6 +1967,8 @@ static void __init check_timer(void)
>
> if ( timer_irq_works() )
> {
> + printk(XENLOG_INFO "IRQ test with HPET Legacy Replacement
> Mode worked. Disabling it again.\n");
> + hpet_disable_legacy_replacement_mode();
> local_irq_restore(flags);
> return;
> }
I'm not sure of the value of the log message. Furthermore, considering
plans to make XENLOG_INFO visible by default in release builds, when
not purely a debugging message. I'm curious what other x86 maintainers
think ...
Jan
|
