[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 1/4] xen/pci: rename local variable to address MISRA C:2012 Rule 5.3
- To: Nicola Vetrini <nicola.vetrini@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 31 Jul 2023 16:16:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l2nqBMasysDSGbivjSfZQvRhH6HyTeLAFSMh/oEQi1M=; b=V98+lINXIMEgpYGRkwCphfhbuonohW/3EOPF+hzoFxEFrXF83JRfIClZUFmk9H2dMtjkz31fmBMvV851CpONh3QSFKbZqLVv0nTq5eh8Atq4DxWFAYnAPhwwF/5YTsj03CqGFH3HcSLhl9DT38IgqWq2B51wZxz82dGLy0eRFtT5oqGCwDqIrGK9o2Kqr/mhePnK2lH+ja13O9r5EMjokA67sU9ledULnF+M+RCM5lmhFgBYk/h87CnytEGD4xvb+OsjprdHFA8H3gTc+gm2Bd4UZt1I9xlIoob62IhjzxCTnWA5EGPrZDo2xP5cMqEGdo88NbHLr2X1IWUccunJAA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fNF1YZxS0VYvdN0ByNpcQ6NHufpW08bo+J0BlsQkXqtw/gAOkmti9gTs13uoVUjGLdKPX8nElpB08/SGo3bijXS1/WctK2oBMa2Nwt2IZBTsgZXdXXCZxQhfpnITcmvBg4xjkneN9BFCqGfJC07oJY9cqmH6R7VDupGsLqQdOcCrtDJGFbtkDLXGYRzTqQbVUg+jWNIiho/xtSJw8YenhZxZDKTbUSRMHEdrWwdk8NUdox/CAzZZgPQZk4yu/N/6rC/oJdBPOw38OxEc5nqugfeXuzovO91WlIFi+6FtzYbrn0fKZ4Wr/7thWVhMnd/fIZ6HGiu0qI2zV/bGyaV77g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: sstabellini@xxxxxxxxxx, michal.orzel@xxxxxxx, xenia.ragiadakou@xxxxxxx, ayan.kumar.halder@xxxxxxx, consulting@xxxxxxxxxxx, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 31 Jul 2023 14:16:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 31.07.2023 15:34, Nicola Vetrini wrote:
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -650,12 +650,12 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
> struct pci_seg *pseg;
> struct pci_dev *pdev;
> unsigned int slot = PCI_SLOT(devfn), func = PCI_FUNC(devfn);
> - const char *pdev_type;
> + const char *pci_dev_type;
I've always been wondering what purpose the pdev_ prefix served here.
There's no other "type" variable in the function, so why make the name
longer? (I'm okay to adjust on commit, provided you agree.)
Jan
|
