[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 7/7] xenalyze: handle more potential exit reason values from vmx.h
- To: George Dunlap <george.dunlap@xxxxxxxxx>
- From: Olaf Hering <olaf@xxxxxxxxx>
- Date: Tue, 1 Aug 2023 14:13:17 +0200
- Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1690892006; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=cjRqM+XjqX1Xuvw0nxwkdauQMImA252wVov7Kg5/gfo=; b=EsDRaa/NnC7MtoLZWYjjNxltk6iEUz3BboFvsMj0MP14/dh03LSy5sxicaKWlAX2dL cGQzGxcnaCg7fvyAd40JsGcS8B54c7Ye05oahU9KWW2bR1qIdajs1/TjtQk/SGVmQ4HH 5kd8rUr/tmNClZ6AtSFqlWqRXxI6BWj9+8BfFRgeNKJFq3WpwpSo6JndmcWVqFrwhT4l J19bffWRasdD/Juit9zV8Me+JQ2loGAfgJ+Lbhs+s8SDzab0XAbUkOSXcsPVwYVmij6m xrai54viwlGG1sJC8F18n5RRDuJihMa9ZKBg4G8K0CTzoVSupay01QTJxdjsM78Lk0N5 3xIw==
- Arc-seal: i=1; a=rsa-sha256; t=1690892006; cv=none; d=strato.com; s=strato-dkim-0002; b=hlyrkG3upPwylhpKCY70T7olKKv3MPc3Ro+hkooftpd3KrftJ4p99qPdLYStHTLb82 TwULyqqsWs8xS47amaK1otp2OskjtH8thHyNXfabo63732WWKzYvYUam4mDVRlhlxB6P AtmCUP5anXT54cwgRCQGbC69Er5P6UZK8V1V9/Kgn4JDBFkvhbVvj9ibO9VYhbdfGVX1 RE2LBkWUS3d+zNlTuAeUC+7f65RzZTWQWpvQl0XnEq2SPscmwfyngZaPafd+p2pPggHY nXdFHQllRtmsjvDvTgTPIGh1LnZVvF5MIaLJUGwQzftBumuEN5U8qRBGUpbh9WF9b0Ue tjbw==
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Delivery-date: Tue, 01 Aug 2023 12:13:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Fri, 28 Jul 2023 21:35:54 +0100 George Dunlap <george.dunlap@xxxxxxxxx>:
> Everything looks good (including adding the missing strings), except for
> the removal of the fixed array size. Call me paranoid, but if we define it
> as REASON_MAX length, then there will never be any way that a value less
> than REASON_MAX causes a segfault (and if we assign a value higher than
> REASON_MAX, the compiler will complain); whereas if we make it variable, we
> leave open the possibility that someone won't update REASON_MAX properly,
> resulting in either segfaults (if REASON_MAX is too high) or missing
> strings (if REASON_MAX is too low).
I think the code needs to be rearranged to work with "array_size" instead.
Olaf
Attachment:
pgpSw9jMmScam.pgp
Description: Digitale Signatur von OpenPGP
|
