[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/5] xen/ppc: Switch to medium PIC code model


  • To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 1 Aug 2023 14:20:40 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cJAsgBWzXbaUDPMv8WqrnEVuL1ySu6i20kYftQ3JtMw=; b=j5VssgTIMw5QIqaIGvuaFyZq8LjLq8EgcfHNYnbm/HRm0nk1fow9P1Y28pfFtcaLEo4hxsKWjC0IHQgKX4YCkWsTmaFTEyEIQrlSJulox9OJ4mYrxiSVL8yXZ8Rj4lw3J5vbh5W0L54ySK3sU1AlpGusewp0MjbhNA0UZmHEeXB+VzmoYDY4Y5qy8J7uZQpm4sJ8+gC2Icm/uKMweddmoNGM5iZihXingJ811WBLWiNtBd0sU4g8guASj67lR/0jJIOLgdiz5+HS2CEjFcE1DVon/b3jR/IS6M0Yc6XypCp5QewbaY51sO8XpylH16V9XpKfKsxv7EhPb/3/KRIJ8g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMSF/kDxDrmlWXFk5HTkBqPsaKf3b7eKWaIXNI6s6F5lEmOL6uC03xMJktkxNLFJk/g9ONNrRa5HfrrRG0Z9IpOcnjFqlQ2TO7yQCmVv94p2H27Gwt52f4CJWu7KDvyqwm3ibIFUCqg0DPjr9bgbibacvyPL9EH32tAsRUVRTZWrdXbas8oZ9nSEI9X9Y4zeZF4YgtZLCsu4Rb0/V+wicT3vK0Yobyq7n0IJy64CwTGux2UOmez/0emk61Oa+dB/IIWfvyoZVLFG5UJfpsLGteXDamehZ/3XSDBeHRmbEg1uddxURAd+f8Q5atpYR7iLsj+B4nSssKKdcMUZXqsncA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 01 Aug 2023 12:20:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 28.07.2023 23:35, Shawn Anastasio wrote:
> @@ -11,16 +13,19 @@ ENTRY(start)
>      FIXUP_ENDIAN
>  
>      /* set up the TOC pointer */
> -    LOAD_IMM32(%r2, .TOC.)
> +    bcl          20, 31, .+4
> +1:  mflr    %r12
> +    addis   %r2, %r12, .TOC.-1b@ha
> +    addi    %r2, %r2, .TOC.-1b@l
>  
>      /* set up the initial stack */
> -    LOAD_IMM32(%r1, cpu0_boot_stack)
> +    LOAD_REG_ADDR(%r1, cpu0_boot_stack)

Question: Would perhaps make sense to use %sp and %rtoc in place of
%r1 and %r2 (not just here of course)?

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.