[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 1/6] dom0: replace explict zero checks
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 2 Aug 2023 09:42:20 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5Wn7uAtj3uJy6zSmTzq4KrF5V4bBuF2v5ugXcovyBDE=; b=SrKunJLJ/OI7kwx7ZSVeB6pfZj9M+8+AXqL0EL4gByuRBrO5fiUU013mAdSqXI6AEqoa7G7FHdPPYH98CuiAZc2Fm1/5A/gQQBzfu1gmoUFFSJGdzCGv/4L+aYYFd+CZnoH/cSLhYdFpKVcNrPgf12Qx0r/Vaj0U/xev4KLqRL71aoxPooV1qfr+KVL9yTK3Pcl5Qqp1KQ+Ko6SOTxed+PpNDih0i/DNtMG/fohq3OHjam7yT5WWSaq5ym6sG5O9fY+XZINgR/ptMGWsbTwjAxd+TpqIlJWfh3AS4oA4rtyN8wVMym5nm/3cPtd4lZz3SznxxeoZjW9uNc492xStGw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VQNDVesECgA8x0MH6Po4rUnBqEetg29KdK5Bmov0mumH14YwYpxuLI47MNE22NmVvEuryf41duEbODrCoruFh5du+lYLvU0/SBggm8/ZJtxZ0xWh3TvqZ5wYIpro7ZfS5dJFn45hRY3hgmO7Cb8x0O89pFA1juc8xvmhXL1pWP9AJAVprzPEEpJQEZIjCGk8QFeRIzDxCFC8nidzkpUUsA3H/4ELakvTtijtkHcitwJHaIwjpudajpK/iHpR+2ntX3d8yaX5yrk7skBBJdB8h77Hg1JQ/RBf3Y99PQHqp2OCszHJMuOmJ6O4HOJEk4prUq4VRAccI0JI0Vsjnzul5A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Nathan Studer <nathan.studer@xxxxxxxxxxxxxxx>, Stewart Hildebrand <stewart@xxxxxxx>, Dario Faggioli <dfaggioli@xxxxxxxx>, roberto.bagnara@xxxxxxxxxxx, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 02 Aug 2023 07:42:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.08.2023 02:24, Stefano Stabellini wrote:
> On Tue, 1 Aug 2023, Daniel P. Smith wrote:
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -1058,6 +1058,13 @@ void scheduler_disable(void);
>> void watchdog_domain_init(struct domain *d);
>> void watchdog_domain_destroy(struct domain *d);
>>
>> +static always_inline bool is_initial_domain(const struct domain *d)
>
> I know you used always_inline only because is_hardware_domain just below
> also uses it, but I wonder if we need it.
>
> Also, Robero, it looks like always_inline is missing from
> docs/misra/C-language-toolchain.rst? Or do we plan to get rid of it?
Under "Non-standard tokens" we have both __inline__ and __attribute__
listed, which I think is enough to cover this specific case as well?
Jan
|
