[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] arm/gicv2: make GICv2 driver and vGICv2 optional



Hi Luca,

On 02/08/2023 19:48, Luca Fancellu wrote:
diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index 5cdba07df964..93309cd49144 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -18,6 +18,7 @@ config ARM
         select HAS_PMAP
         select HAS_UBSAN
         select IOMMU_FORCE_PT_SHARE
+       select GICV2 if !GICV3 && !NEW_VGIC
config ARCH_DEFCONFIG
         string

If I’ve played a bit with the menuconfig and it selects GICv2 if no other gic 
driver is selected, so basically
as before when gicv2 was always enabled.
If everyone agrees I can use this solution and include it in the next push

I am not thrilled with this approach. I understand that the default today is GICv2, but why should it continue to be like that?

Even if we were switching to GICv3, it feels rather a odd approach because you would make it work for one set of the users but not the others.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.