[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] console: generalize the ability for domU access
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Date: Thu, 3 Aug 2023 09:12:39 -0400
- Arc-authentication-results: i=1; mx.zohomail.com; dkim=pass header.i=apertussolutions.com; spf=pass smtp.mailfrom=dpsmith@xxxxxxxxxxxxxxxxxxxx; dmarc=pass header.from=<dpsmith@xxxxxxxxxxxxxxxxxxxx>
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1691068363; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=p+i+tVUmrsXbTJPh7J2O2HcVZAW1GBPm8/kJrcCQziQ=; b=HmkZojdErOmaW8xbYJKKP6X6BtaE3dQx8oGsIJJWeCitpEzy15wI/RrsrDEY7T/WI9ScJeDbm9AlpNJrzTOOxZvf1JXDMrLUWXM8YHak12EwoFWbGlMFaOfxk7Tw9IGFLux8y7wTKl89AYlIhjVfd0QE6aLeseIOY8JYiymVJk0=
- Arc-seal: i=1; a=rsa-sha256; t=1691068363; cv=none; d=zohomail.com; s=zohoarc; b=KdBsPb/36Bx0f6EAyNk9GAejDbzVKtsrpfId3o9DsKSakDAiXm5iaPRAD3zydRDbmASP0TEiC96RfTIVn12R1QBFxj8TU9SmO2w5UygtJyzXafjUtlwTLBl2tPiE80EoDRd+wjpXVwLeDHqCeWjtwzjbVfftZOskzYHYf+TgOQ8=
- Cc: Christopher Clark <christopher.w.clark@xxxxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 03 Aug 2023 13:13:02 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 8/2/23 19:58, Stefano Stabellini wrote:
On Wed, 2 Aug 2023, Jan Beulich wrote:
- for ( ; ; )
+ if ( d == NULL )
This covers both Xen receiving input and the domain receiving input having
gone away. Originally in the latter case the next sequential (in domid
numbering) domain would be switched to. In the new logic you start over
from the beginning of the domain list. Such a change in behavior (if
deemed acceptable at all, which I'm not convinced of) needs calling out in
the description.
I think it would be best to keep the current behavior as we already
have people using it unless we have strong reasons to change it.
I agree and intended to keep the order of switching but I disagree on
keeping the complete current behavior. I mean that by the complete
current behavior being defined, at least for Arm, as meaning only the
domains created at boot. The is_console flag in struct domain is the DAC
equivalent to granting the FLASK access XEN__READCONSOLE to a domain, it
was just never implemented/used until domoless enable it. An intended
consequence of this patch is to ensure any domain granted the privilege,
either through the DAC is_console or FLASK XEN__READCONSOLE, is included
in the rotation regardless if the domain was created at boot or at runtime.
v/r,
dps
|
