Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

Hi Tamas,

May I have your ack on this change?


On Thu, 27 Jul 2023, Federico Serafini wrote:
> Change parameter name in monitor_domctl() declaration for
> consistency with the corresponding definition.
> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
> of an object or function shall use the same names and type qualifiers".
> 
> No functional changes.
> 
> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
>  xen/include/xen/monitor.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
> index 6b17a93071..713d54f7c1 100644
> --- a/xen/include/xen/monitor.h
> +++ b/xen/include/xen/monitor.h
> @@ -27,7 +27,7 @@
>  struct domain;
>  struct xen_domctl_monitor_op;
>  
> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
>  void monitor_guest_request(void);
>  
>  int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
> -- 
> 2.34.1
> 
>