[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 09:27:28 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H1CR+QH2QRjA3s8fhRSnMYrugfzzVYpsSu4bpcG0fP4=; b=buS4HUvG0RtpUSdKKKR7S+2vpPwHAW72Lpjk9AHtS1czhCH5AlDLzuXhq2r0YxX8535tfBzGdncswMigAY4HexVOOmRZvigFHQu5Or1Oz3QbmjptR3h57OciYrKjwDi8BHRBXPW5vmncMKZOb+k/Iy/jwjjo2t71HqDReOTUqpF3J9KdLkqdlGWXIXAMkpHUiNVu5uFEED/BzWepgSl1iCyV3IgQfSvvX25S50E6skw26CyjbBvONDnaC0M//d8wOUebDWQzC/IF2889lGm7yfDhlIHXcnu0iyVJnc0mEMxSJhcSkvVxSfONhTrBqyIHdRp2vW6wHHzc9bzWID+n0A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnzI7vYF/6vtpJQ3Gdfdm5SonW9mWy+Bl103XgymBNzrrz/5qdx1azfsvXK5fGusFq+QFJKIYTKRU+iUu1q24+JSgHJ+z6Itckw/KRC8ZECx+lyU9PnDNpEPrTenrDz7trCcn5+ftdiIRtFaBViwEnyNSjuRDZUq91tvV6Emz8OwyZWyQ37zd7bU4SuUnNFkkgmAdviBnMO3vuBUC12aOKZzXb88FFOhrH1sOYLWUxIv6d5uJmuD4uB6XxR9RJGlT1szlXnfgkY6xkIh3KPxbLnn4s5UETphWmDeqKp8WHLrA6KuPi4e+W1VlCupvJwloJgi7wxYOCKFwuHMWAyK3Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, consulting@xxxxxxxxxxx, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, federico.serafini@xxxxxxxxxxx, tamas@xxxxxxxxxxxxx
- Delivery-date: Tue, 08 Aug 2023 07:27:42 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.08.2023 23:39, Stefano Stabellini wrote:
> Hi Tamas,
>
> May I have your ack on this change?
I see you committed this, and there is an ack in the commit, but I can't
see any ack on list (incl when checking mail archives, to exclude an
issue with my mailbox).
Jan
> On Thu, 27 Jul 2023, Federico Serafini wrote:
>> Change parameter name in monitor_domctl() declaration for
>> consistency with the corresponding definition.
>> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
>> of an object or function shall use the same names and type qualifiers".
>>
>> No functional changes.
>>
>> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
>
>
>> ---
>> xen/include/xen/monitor.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
>> index 6b17a93071..713d54f7c1 100644
>> --- a/xen/include/xen/monitor.h
>> +++ b/xen/include/xen/monitor.h
>> @@ -27,7 +27,7 @@
>> struct domain;
>> struct xen_domctl_monitor_op;
>>
>> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
>> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
>> void monitor_guest_request(void);
>>
>> int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
>> --
>> 2.34.1
>>
>>
>
|
