Re: [XEN PATCH] xen: change parameter name in monitor_domctl() declaration

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 8 Aug 2023, Jan Beulich wrote:
> On 04.08.2023 23:39, Stefano Stabellini wrote:
> > Hi Tamas,
> > 
> > May I have your ack on this change?
> 
> I see you committed this, and there is an ack in the commit, but I can't
> see any ack on list (incl when checking mail archives, to exclude an
> issue with my mailbox).

That is strange! Something appears to be wrong with xen-devel. Adding
George in CC and attaching Tamas' reply.


> > On Thu, 27 Jul 2023, Federico Serafini wrote:
> >> Change parameter name in monitor_domctl() declaration for
> >> consistency with the corresponding definition.
> >> This addresses a violation of MISRA C:2012 Rule 8.3: "All declarations
> >> of an object or function shall use the same names and type qualifiers".
> >>
> >> No functional changes.
> >>
> >> Signed-off-by: Federico Serafini <federico.serafini@xxxxxxxxxxx>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> > 
> > 
> >> ---
> >>  xen/include/xen/monitor.h | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/xen/include/xen/monitor.h b/xen/include/xen/monitor.h
> >> index 6b17a93071..713d54f7c1 100644
> >> --- a/xen/include/xen/monitor.h
> >> +++ b/xen/include/xen/monitor.h
> >> @@ -27,7 +27,7 @@
> >>  struct domain;
> >>  struct xen_domctl_monitor_op;
> >>  
> >> -int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *op);
> >> +int monitor_domctl(struct domain *d, struct xen_domctl_monitor_op *mop);
> >>  void monitor_guest_request(void);
> >>  
> >>  int monitor_traps(struct vcpu *v, bool sync, vm_event_request_t *req);
> >> -- 
> >> 2.34.1
> >>
> >>
> > 
>

--- Begin Message ---

• To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
• From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
• Date: Sat, 5 Aug 2023 13:05:44 +0200
• Authentication-results: posteo.de; dmarc=none (p=none dis=none) header.from=tklengyel.com
• Authentication-results: posteo.de; spf=pass smtp.mailfrom=kernel.org
• Authentication-results: posteo.de; dkim=pass (2048-bit key) header.d=tklengyel.com header.i=@tklengyel.com header.b=NZXhVc+1; dkim-atps=neutral
• Authentication-results: smtp.kernel.org; dmarc=none (p=none dis=none) header.from=tklengyel.com
• Authentication-results: smtp.kernel.org; spf=pass smtp.mailfrom=tklengyel.com
• Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, consulting@xxxxxxxxxxx, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Federico Serafini <federico.serafini@xxxxxxxxxxx>
• Delivered-to: stefano-oss@xxxxxxxxxx
• Delivered-to: sstabellini@xxxxxxxxxx
• Dmarc-filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 348A5C433C8

<div dir="auto"><div><br><br><div class="gmail_quote"><div dir="ltr" 
class="gmail_attr">On Fri, Aug 4, 2023, 11:39 PM Stefano Stabellini &lt;<a 
href="mailto:sstabellini@xxxxxxxxxx";>sstabellini@xxxxxxxxxx</a>&gt; 
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Tamas,<br>
<br>
May I have your ack on this change?<br>
<br>
<br>
On Thu, 27 Jul 2023, Federico Serafini wrote:<br>
&gt; Change parameter name in monitor_domctl() declaration for<br>
&gt; consistency with the corresponding definition.<br>
&gt; This addresses a violation of MISRA C:2012 Rule 8.3: &quot;All 
declarations<br>
&gt; of an object or function shall use the same names and type 
qualifiers&quot;.<br>
&gt; <br>
&gt; No functional changes.<br>
&gt; <br>
&gt; Signed-off-by: Federico Serafini &lt;<a 
href="mailto:federico.serafini@xxxxxxxxxxx"; target="_blank" 
rel="noreferrer">federico.serafini@xxxxxxxxxxx</a>&gt;<br>
<br>
Reviewed-by: Stefano Stabellini &lt;<a href="mailto:sstabellini@xxxxxxxxxx"; 
target="_blank" 
rel="noreferrer">sstabellini@xxxxxxxxxx</a>&gt;<br></blockquote></div></div><div
 dir="auto"><br></div><div dir="auto">Acked-by: Tamas K Lengyel &lt;<a 
href="mailto:tamas@xxxxxxxxxxxxx";>tamas@xxxxxxxxxxxxx</a>&gt;</div><div 
dir="auto"><div class="gmail_quote"><blockquote class="gmail_quote" 
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--- End Message ---