[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2] x86/hpet: Disable legacy replacement mode after IRQ test
- To: Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Aug 2023 11:59:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PYk04VqF6SMS20j6DS9Kk5uPePKrMrEqgZXcw7Zbbz8=; b=BIUPH1yuzZapqFZpp+C4bfgFtnlOWa7XnZ7TpZ4s98I4iENZU/+y/a1XYUjg8Pl0+RAj1c9THLvr1NLquhzxbFkJn4lYjM4pTRV8ORsa+izO1piUJQSYbtOvz1vXzKSK9mnAjZhpm93OkoxQQrBqnwwzgldvB4RbX16YwXgzNuzvAXwtFz4oLKiN7ztS659h+4fciCFBxCm6SCAIKU0Obd+dk8EmAcvTCtBUl2Vru5RzrA4hWjU8Zy2FarR5S3n1l9GNKDorOjxi6RvrcC6PkomLENAJDZZhvoPcgoaXjGzXO6g2m/T0bL5WJqNuxcP4/LdAfMn5IKznSi/IzsnM/w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BsUB3c+QvrNE2qKQS3ceNVeBVEGIhTieTN3B+GmxNwdzVbeaujMrPpqQm6jAnot+8UMOKkMzTbAxneKtzdYsqaSL0j7ywZIEEjm1Y+rd9ukLrP2l8pKI3t5x8ss+hJiZuTwF9b/aNIdAkG+gZVSW9I6RKh5w+61SOhFN1c+tXbEnFNRiFTQJzv4Or/F6rBLMPwnCwnlCj47Pxa5XAiDJzkY61cbPVGz0NX9hqGgvXXmRrHq/Y4Qj5DYI4o+wwGrEKXJW9kAd7iXq+C+o7awjDCAjL1kC4DY8zEowKFzGZk/WjCo7yqCVpFrqRj6KiEFFo6gKOhisUgeV7K9tKbaNOA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 07 Aug 2023 09:59:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.08.2023 11:47, Simon Gaiser wrote:
> Jan Beulich:
>> On 31.07.2023 12:32, Simon Gaiser wrote:
>>> --- a/xen/arch/x86/io_apic.c
>>> +++ b/xen/arch/x86/io_apic.c
>>> @@ -1967,6 +1967,8 @@ static void __init check_timer(void)
>>>
>>> if ( timer_irq_works() )
>>> {
>>> + printk(XENLOG_INFO "IRQ test with HPET Legacy Replacement
>>> Mode worked. Disabling it again.\n");
>>> + hpet_disable_legacy_replacement_mode();
>>> local_irq_restore(flags);
>>> return;
>>> }
>>
>> I'm not sure of the value of the log message. Furthermore, considering
>> plans to make XENLOG_INFO visible by default in release builds, when
>> not purely a debugging message. I'm curious what other x86 maintainers
>> think ...
>
> As far as I can see nobody has so far voiced an opinion. How about you
> tell me the level and message you would prefer and I send a new version
> of the patch with it.
XENLOG_DEBUG or even dprintk(). Also note that generally we avoid full
stops in log messages.
Jan
|
