[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3] x86/hpet: Disable legacy replacement mode after IRQ test
- To: Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 22 Aug 2023 08:45:51 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JN4afLUHwdu/SbqTyT1sDAKRUKs8AVVdi8jlPxvSCHQ=; b=asaDQ2NzBsT1+X1pHN+socHHLy8VPiXalPqdGr3ubvSmqCFqz4TKtaUZwCdDbLVN7wed//F9XvcA+xm6T1154J+SmmFQMcEukvbDh/xqQE8t0AmlBtkRywH1Y0OQm/89igeLMsNt47wp/hQLwlENFMiKSUEj0+GT/SCcMXzzp0zFEBDx3akY0uDm9+Z2c860//+jofyHwn2uFj1cn32MgOo+mpAVQRlo6zZ73jyWgKXC4lWaq5fM3B5WpQ5dChfDs23+IpUOS/O7sXUCFFGGB3F+JYitg0O5BG3FqbUtq5rCqwaiJc49HsnWb2Jm/LBnS9Nk0vhoxtswftCBxmtuww==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lRuglntHcpsw3k6sEuEJPGlWb2NebDrh4NUgXhfofGu84y9wnrCb8wZt67V/0olp9rg9+2VoBOtko8bJ9H5mSe6WvqALpn3IZynrrg5ezvirawOIDJGAzQwr5XpO8CShBElZp+Oqu9duCNixfoGRWI/7NqKb9umqiIPwS09znEsHYOKjp7CkR3HKj3UtyG/pL7qqJ48GrQn/2XZVTheTFUY6xa6YoELVueJnrjUUS7ha/k6CSbNsEXHYgrOCzCANERSSB5U2q7/kspj6OYUt5XLTPADDnoa7CnL/uDOJzK67VG8PSehRySArJOPwZdLvh2Vj6dmuX0J/vApQho/u5w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 22 Aug 2023 06:45:59 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.08.2023 13:28, Simon Gaiser wrote:
> As far as I understand the HPET legacy mode is not required after the
> timer IRQ test. For previous discussion see [1] and [2]. Keeping it
> enabled prevents reaching deeper C-states on some systems and thereby
> also S0ix residency. So disable it after the timer IRQ test worked. Note
> that this code path is only reached when opt_hpet_legacy_replacement < 0,
> so explicit user choice is still honored.
>
> Link:
> https://lore.kernel.org/xen-devel/cb408368-077d-edb5-b4ad-f80086db48c1@xxxxxxxxxxxxxxxxxxxxxx/
> # [1]
> Link:
> https://lore.kernel.org/xen-devel/20230718122603.2002-1-simon@xxxxxxxxxxxxxxxxxxxxxx/
> # [2]
> Signed-off-by: Simon Gaiser <simon@xxxxxxxxxxxxxxxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Albeit I'll likely wrap the printk() slightly while committing.
Jan
|
