[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: Drop opt_pku entirely
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 7 Aug 2023 14:45:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iXXnkgZttQSW3pq00KkdBdU/MEjO96Uage0DISgZQOs=; b=YLBKioT09kwWSGozCYT9wom5MR9wECHsvuZuO50XN16qwkYdTRuY+5kxKhw9UlaBEOa9/YP1XHn0qDS17m1bBNl5yqQQNChkPCpxCK/bziVGlvt6XFodGW/WUSf1ZvAtM1+tMd2wRMmXVDPf/meUJCIbzkeE8YDgnYEtbCKAyHtGe5sDogEPMomkanLx/axCsLuQX4VzeW/kT/RLwotOQ+PxKVHn0pqcjLKs8b0KeSZHPOeZh/atEXZnqyEkAVlZMb9f4gRtvn/CW/IK+SMiTvVDwdGm7WYRo/FYKCRjl0ooqy1LE8Zoy0MzU+cM1MEIN7PjjW49MwRDAO9o3cIUZg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n0c2DjAj5CZt13GgTyS2VXcDvnHWQlsAdQol4i11qOhucJrbQkKVfpbva7Uz1ImQUE2MNoJRcMZdzvmCNMY0lbK+u4DVBRbGdKmTEoH4O0ynSP/WN93jHeEvBtighlA0kozdlQA2rXZkO9/NyUJij+DXelAdy80Fd7N4RJfl880kaF6HD1J4mr0IAbVF07LNTQvnoaya4b1aovCGHLONoGCvPzB3f/OhV9I2sylp8G5fD58Z+NommTXH78hYF+47dIZQep4mqRlWO14WJ8MscXRf+RUv4sEUC/oOjQXzKk5AigBBpM8l+UF0ULHeDo2fBud2p6XHzSdXjSshLNQHOg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 07 Aug 2023 13:45:53 +0000
- Ironport-data: A9a23:A/Km7KkpBdI+jOuObNGbxJTo5gy5J0RdPkR7XQ2eYbSJt1+Wr1Gzt xIXUWCEafjeZmujKNskPYy/oBgF6MWEz99qHgFt+yE1RiMWpZLJC+rCIxarNUt+DCFhoGFPt JxCN4aafKjYaleG+39B55C49SEUOZmgH+a6U6icfHgqH2eIcQ954Tp7gek1n4V0ttawBgKJq LvartbWfVSowFaYCEpNg064gE0p5K2aVA8w5ARkPqgb5ACGzhH5MbpETU2PByqgKmVrNrbSq 9brlNmR4m7f9hExPdKp+p6TnpoiG+O60aCm0xK6aoD66vRwjnVaPpUTbZLwXXx/mTSR9+2d/ f0W3XCGpaXFCYWX8AgVe0Ew/yiTpsSq8pefSZS0mZT7I0Er7xIAahihZa07FdRwxwp5PY1B3 eYgAxk9SxGjvdmz34yXZLl3qs99KPC+aevzulk4pd3YJdAPZMmbBonvu5pf1jp2gd1SF/HDY cZfcSBocBnLfxxIPBEQFY46m+CrwHL4dlW0qnrM/fZxvzeVkVw3ieCxWDbWUoXiqcF9t0CUv G/ZuU/+BQkXLoe3wjuZ6HO8wOTImEsXXapLTe3mrqI72QD7Kmo7MjRNb163+/mA03GXX8BuK 0UUxAc3ov1nnKCsZpynN/Gim1aGtBMBX9tbE8Uh9RqAjKHT5m6xGWwsXjNHLts8u6ceZTEsz E7PoNrvChRmqrjTQnWYnp+EoDX3NSULIGsqYS4fURBD89TluJs0jB/EUpBkCqHdszHuMTT5w jTPoC1ggbwW1JYPz//ipQyBhC+wrJ/USAJz/h/QQm+u8gJ+YsiiepCs7l/Yq/1HKe51U2W8g ZTNoODGhMhmMH1HvHbQKAnRNNlFP8q4DQA=
- Ironport-hdrordr: A9a23:Le1WkKkTMJH+4bbbWUwOGSX/d6zpDfMxiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0msjKKdkrNhWotKOzOWxVdATbsSl7cKpgeNJ8SQzJ8/6U 4NSdkaNDS0NykAsS+Y2njHLz9D+rm6GcmT7I+xrkuFDzsaE52Ihz0JdTpzeXcGIDWua6BJcq Z0qvA3xQZJLh8sH7iG7zQ+LqD+T5qhruOVXTc2QzocrCWehzKh77D3VzCewxclSjtKhZsy7G TflAT9x6O799W20AXV2WP/54lf3IKJ8KoOOOW8zuwubhn8gAehY4psH5WEoTAOuemqrHo6jd XWpB8kHsJrr1fcZHu8rxfB0xTplBwu93jh41mFhmaLm721eBsKT+56wa5JeBrQ7EQt+Pl6za Jwxmqc875aFwnJkijR78XBE0gCrDv/nVMS1cooy1BPW4oXb7Fc6aQZ4UNuCZ8FWAb38pouHu VCBNzVoNxWbVSZRXbEuXQH+q3mYl0DWjO9BmQSsM2c1DZb2Fh/0ksj3cQa2kwN8ZosIqM0kN jsA+BNrvVjX8UWZaVyCKMqWs2sEFHARhrKLSa7PUnnPLtvAQOMl7fHpJEOoM26cp0By5U/3L 7bVklDiGI0c0XyTeWTwZxw9AzXSmnVZ0Wt9ihn3ek6hlTAfsuvDcXaI2pe1/dI4s9vTPEzYs zDe66/WJTYXCzT8YUg5XyLZ3AdEwhZbCQvgKdJZ7u/mLO7FmTUjJ2qTB/yHsuaLd92YBK3Pl IzGB7OGe5n0meHHlfFvTm5YQKZRqW4x+M+LJTn
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07/08/2023 2:34 pm, Jan Beulich wrote:
> On 07.08.2023 15:21, Andrew Cooper wrote:
>> On 21/06/2023 8:37 am, Jan Beulich wrote:
>>> On 20.06.2023 19:47, Andrew Cooper wrote:
>>>> --- a/docs/misc/xen-command-line.pandoc
>>>> +++ b/docs/misc/xen-command-line.pandoc
>>>> @@ -1950,16 +1950,6 @@ for all of them (`true`), only for those subject to
>>>> XPTI (`xpti`) or for
>>>> those not subject to XPTI (`no-xpti`). The feature is used only in case
>>>> INVPCID is supported and not disabled via `invpcid=false`.
>>>>
>>>> -### pku (x86)
>>>> -> `= <boolean>`
>>>> -
>>>> -> Default: `true`
>>>> -
>>>> -Flag to enable Memory Protection Keys.
>>>> -
>>>> -The protection-key feature provides an additional mechanism by which
>>>> IA-32e
>>>> -paging controls access to usermode addresses.
>>>> -
>>>> ### ple_gap
>>>> > `= <integer>`
>>> Elsewhere you said that we kind of imply that only the explicitly named
>>> sub-options of cpuid= are supported. If that's the case (which could do
>>> with saying more explicitly), you will want to add "pku" there in order
>>> to not regress what is (deemed) supported.
>> I disagree. I can say it was equivalent to X without X being an
>> explicitly supported option.
>>
>> PKU shouldn't be adjusted by either of these options; it should be
>> controlled in the VM config file (if at all). I'm unwilling to make any
>> suggestion that this is supported.
> Hmm, so you're suggesting "pku=" use was unsupported, too? If so, perhaps
> worth adding the word "unsupported" to the CHANGELOG.md entry.
Well - it's just hiding a feature so nothing (interesting) is going to
break. But it also isn't an option that anyone ought to have been using.
> At which
> point I'm fine with no adjustment to cpuid= doc. And then also
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Thanks. I'll tweak.
~Andrew
|
