Re: [PATCH 1/4] xen/ppc: Switch to medium PIC code model

[Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>]

On 8/2/23 2:16 AM, Jan Beulich wrote:
> On 02.08.2023 02:11, Shawn Anastasio wrote:
>> --- a/xen/arch/ppc/include/asm/asm-defns.h
>> +++ b/xen/arch/ppc/include/asm/asm-defns.h
>> @@ -16,6 +16,13 @@
>>      lis reg, (val) @h;                                                      
>>  \
>>      ori reg, reg, (val) @l;                                                 
>>  \
>>
>> +/*
>> + * Load the address of a symbol from the TOC into the specified GPR.
>> + */
>> +#define LOAD_REG_ADDR(reg,name)                                             
>>  \
>> +    addis reg,%r2,name@toc@ha;                                              
>>  \
>> +    addi  reg,reg,name@toc@l
> 
> Didn't you indicate you'd add blanks after the commas (also) here?
> 
>> --- a/xen/arch/ppc/ppc64/head.S
>> +++ b/xen/arch/ppc/ppc64/head.S
>> @@ -1,6 +1,7 @@
>>  /* SPDX-License-Identifier: GPL-2.0-or-later */
>>
>>  #include <asm/asm-defns.h>
>> +#include <asm/asm-offsets.h>
>>
>>      .section .text.header, "ax", %progbits
>>
>> @@ -11,16 +12,19 @@ ENTRY(start)
>>      FIXUP_ENDIAN
>>
>>      /* set up the TOC pointer */
>> -    LOAD_IMM32(%r2, .TOC.)
>> +    bcl         20, 31, 1f
> 
> Hard tab slipped in.
> 
> I'm happy to take care of both while committing; then:
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks, Jan. Just to clarify, are there any outstanding comments that I
need to address in this series, or are they all able to be handled by
you during commit?

> Jan

- Shawn