[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] xen/ppc: Switch to medium PIC code model
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 2 Aug 2023 09:16:50 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KsbyRsYos73yyDPCpkKl5JV5OdZ2xsaCh+55LwFQFm8=; b=eED1apRzQnRCGnfblkw+lDKvLO8LfPMPJeMbquB23U9jlBsMP3Hl9LlDx12w4cbYPG9k7Me2J2K7tor429ralLmay/78Fbd4vA0FDPjESaBDWNMoZIeOaf+vi22LQiA9GZ8LMlcslDlYWP2THIUYvLUyvbiUTIxEVpMxnjjpDF5b1XvNTNWXag98DZjtyDsXfQAmG8/T0LaUvEKZfyIbWgElv96aMkWye/CNga+K66hyIq0yDi9caC2XCvBgn35/DxuabVTh4T2INn9ziaAZH28SfF1hBbr6wm2v0zov83VeOopPlUJx/KKkGAFGvwM1KMC9tut6RAxmj3hnS7G0SQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l2ZfC0DcxMjs8JULLXxV/dh0fWsBzlKM5vwVQGrxq/BSGVmJkEfYZ2DYmWhl6Pkt22oDfw9J/ZmjrxEQY3K/m/P2kCp3/EfqAFtLW2U3M3Y7lbPU3ebZpIJRLo3olTiPL09gqgjsNDGvfMxAsW0d5n9ULpw/WsAObQ9CLB1kkjhRB9BjCYJdUs5uFpU6jbz2p/jkDn+y0fwJgsIsC4S9BHXkDA9m12ld6qtgfGze/hF7w4AImTB+AK4zUb4Ev6gRvkPygcOjXOztv8eQdPlZrd5piXN/vkh1GFFWE8sAfL1iNBCgwhArvCpT/0FA7M3ucrcDio9CLRO0vwGDqHDGhw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 02 Aug 2023 07:17:12 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.08.2023 02:11, Shawn Anastasio wrote:
> --- a/xen/arch/ppc/include/asm/asm-defns.h
> +++ b/xen/arch/ppc/include/asm/asm-defns.h
> @@ -16,6 +16,13 @@
> lis reg, (val) @h;
> \
> ori reg, reg, (val) @l;
> \
>
> +/*
> + * Load the address of a symbol from the TOC into the specified GPR.
> + */
> +#define LOAD_REG_ADDR(reg,name)
> \
> + addis reg,%r2,name@toc@ha;
> \
> + addi reg,reg,name@toc@l
Didn't you indicate you'd add blanks after the commas (also) here?
> --- a/xen/arch/ppc/ppc64/head.S
> +++ b/xen/arch/ppc/ppc64/head.S
> @@ -1,6 +1,7 @@
> /* SPDX-License-Identifier: GPL-2.0-or-later */
>
> #include <asm/asm-defns.h>
> +#include <asm/asm-offsets.h>
>
> .section .text.header, "ax", %progbits
>
> @@ -11,16 +12,19 @@ ENTRY(start)
> FIXUP_ENDIAN
>
> /* set up the TOC pointer */
> - LOAD_IMM32(%r2, .TOC.)
> + bcl 20, 31, 1f
Hard tab slipped in.
I'm happy to take care of both while committing; then:
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
