[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] xen/ppc: Implement early serial console on PowerNV
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 2 Aug 2023 09:10:55 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=y2gsbWAK1hWxBxzH9Ld1Tp9I8VrXn5DEEemrE12FGPw=; b=lfn/6jgUsv4u1FDAR2dpx4fG9oJ/eRbfS7GYaSxj/2roalM/vToND40NvTssX+4LcXTqsdocUk0bXNUpwdml/YZdkvN50p/TApI9uslN77T8wDbwnYDTNUSgZsxwscEiUppJxPapCJE4jbzH7lFAYjUmXsh1v3gzuEE7E5Pp1gYV1st7lEjqKt489sZj0jDHneWquJWHlK+szqKj/VJFsmuE6VCpElVr7h36Z3N+Oxo3iKrT2Rz1bn/u+0V4ge06EpXt//i7ba2uAo9y6kgHU86BEEv8ljVeioPItReEUNhykH8qx11uae0VRy6JY8AK5jVOTIqCOYYjzIQjpfVNIA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aVGlsekUpoVvHp2TRgbmwvf4pU+oAHHhAygHQCUzLUuqbpcvk4RO1cLsJ/2be7T6enreJCKVYV4bSb7cz1/yixkAre69u3B7D9JEvEW7fG6w4GlCGZUImD7wxlVFdy1w9wOqT8sN18yEbASFpoZNS69gSJw1zp/rgFHz15Axu4UP7QhE/0bcPfWs/HaRl2c0rerE0ueAR+3GwyWlC01sg5/JjeXxJE/dfFUkgXRswD52RznLIIZK3k1EmOYFefjRWmXcer4EAin4oD7PEZoooA20EW7uERBNZ3i4J6SSw9qqwC/44mxEHItTGTPSMJmv9kwo6dDUg43nJhsJNpGOfA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 02 Aug 2023 07:11:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 02.08.2023 00:54, Shawn Anastasio wrote:
> On 8/1/23 6:19 AM, Jan Beulich wrote:
>> On 28.07.2023 23:35, Shawn Anastasio wrote:
>>> +static void opal_putchar(char c)
>>
>> Can't this be __init?
>
> Unlike OpenFirmware, OPAL calls are expected to be used by the OS during
> its entire lifecycle, not just during early boot, so the full
> (non-early) serial console driver would likely want to use these
> functions as well.
Well, in the present usage it's unneeded post-init afaict. Hence if you
don't want to add __init until another use appears, please add a
respective remark in the description.
Jan
|
