[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 04/15] xen/sysctl: Nest cpufreq scaling options
- To: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 09:05:15 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TkJ3g32OqlIHjrdAMHwXrRmn+rgF3dKMx4rDtU8a/k4=; b=EQSmMQPbE3kp+FqY4X0CBVOmDFnNTPUMvCrEqRwveKtSjon/r3ZzLZ5EwHLdQrdg/SJNZMwKXbam4D3fOkjhaRMvLmSJz4d+GBgjBQtfZKfZy5bjUn7dgtm6RsyJStQv1vzG+iHEMs52nqHh5TlQFKdlRRIgUiZkBWAp/UwuKjlA6X8qgSw4a+JFoh3RkxsYqFrz7QWvIphQDvhPvqQ3c2h6r64FCNvdTa/nslPger72tqaUxg9cIAA1QF95qEzpDwT9fSKb44iW0TSGbf7a8HmXNgdg98HEf7iHzx0KvSkDRXrjj6nCPEb1jY/Y1NNzxt5ynxSSW77GtBOg+Xcrow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g2/2rqgPHzgsYrFEseDYCrYLX61k61eehvBvsCnsvNZ58LxMGQAIjy5LVLsf8ehStI5D+tDYXz0GXxsVgFRBxYM1DXh0JvxpBhPUbcEBAmZp9OBD7S13ZM03ChIwnqNWOCycnHCRKtvdJUd7DmU1IKWAm8SmgR3JL8mmuwQTwkO39xjnf0bofkSw/T8v5R6kS2lqQ/mmtES1gpQPcQYchRX8Ti8x08B4yWekpRl6dq/FqnDwWbpmy8jq9SZyPz4tzT0zDktoYSQxib1CVG4LxD8AeOhyB2aw0G7Q9vanHB9JJkhEY/Zp9fhQKpGhwFUCRxden0se7QSVkdTfY0JFVQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Jason Andryuk <jandryuk@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 08 Aug 2023 07:05:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.08.2023 20:51, Jason Andryuk wrote:
> Add a union and struct so that most of the scaling variables of struct
> xen_get_cpufreq_para are within in a binary-compatible layout. This
> allows cppc_para to live in the larger union and use uint32_ts - struct
> xen_cppc_para will be 10 uint32_t's.
>
> The new scaling struct is 3 * uint32_t + 16 bytes CPUFREQ_NAME_LEN + 4 *
> uint32_t for xen_ondemand = 11 uint32_t. That means the old size is
> retained, int32_t turbo_enabled doesn't move and it's binary compatible.
>
> The out-of-context memcpy() in xc_get_cpufreq_para() now handles the
> copying of the fields removed there.
>
> Signed-off-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> v8:
> Add BUILD_BUG_ON checks for structs xc_get_cpufreq_para & xen_get_cpufreq_para
>
> v6:
> Add Jan's Reviewed-by
>
> v5:
> Expand commit message
> Change comment to driver/governor
> ---
> tools/include/xenctrl.h | 22 ++++++++++--------
> tools/libs/ctrl/xc_pm.c | 46 ++++++++++++++++++++++++++++++++-----
> tools/misc/xenpm.c | 24 +++++++++----------
> xen/drivers/acpi/pmstat.c | 27 +++++++++++-----------
> xen/include/public/sysctl.h | 22 ++++++++++--------
> 5 files changed, 92 insertions(+), 49 deletions(-)
Since the note in the cover letter may not be noticed - this wants looking at by
a tool stack person.
Thanks, Jan
|
