[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RESEND] libxl: Make domain build xc_domain_setmaxmem() call use max_memkb
- To: Kevin Alarcon Negy <kevin@xxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 09:07:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4K/6ih7WCPUX5PqpeT51DGBp3NNyv+xM1y49KZkLv5c=; b=D1hUKdL/PUTV5P7GBhz3RDCM4PK76H1PsP5kMkHefO9Hl/5x/CBsyXhTGLOCaZLY58Ivv5bHFw2ti7QANOFlyb09aYf6u1vWrG72J9346y3xXEzlN2opWlj+jBQXidFBIQuV+oFHrXY4C90worgkkBa/tjWVDMrjx1Ktys+OES7Rfaba1oiwWxG43Da9f+r/sYpM/93nXPta4+nxtQTHJLZPbbD2r9aYXw/Qr3YabpGYujrhF2d543K9HYv57KSByphUHzig3nnVHMt+qB5PiHocu7jUlPdNfFN0RwybmW/af96tI7dcPbn9IET6W4DQx5P50LchmgC3qxu0Df7NtA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BYpXMwmcGDS1yr/uGYGcKiB8ZsgOU4+ZiTAWqdWcakds6wMpOuu3pxMYy2NsFuF+1242hjpTkvamv+iP4ns6sg8XcveVeRTqV6CZw/l4uU3xyIyyfJxDCLfp1zonSdW8Hnl4pYZO/NI7JLgreZI0iizn8ZNnmZU2UJ0t1YH0qqo5thVHnMX7EkqMkV23Zb9eSFgmf7BgX8HrWWjeSlhh8dmJxsDzrRif9SsGEHNeIHOUVyXZiNFu7A4fw8o7Ckhl2rUNKU8cfCVyt2Uhspra7b28oJ+RdwZbwy3dMgIcv/M9TYRsZfYOccA0CL+gjSWPeVYjxmV/SgANCDD14UuAiQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 08 Aug 2023 07:07:25 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.08.2023 00:16, Kevin Alarcon Negy wrote:
> When building a domain, xc_domain_setmaxmem() is called with target_memkb
> (memory in domain config file).
> If a config specifies maxmem > memory, any attempts to increase the domain
> memory size to its max,
> outside of xl mem-set or xl mem-max, which already call xc_domain_setmaxmem()
> properly, will fail.
> Changed xc_domain_setmaxmem() call inside libxl__build_pre() to use max_memkb.
>
> Signed-off-by: Kevin Alarcon Negy <kevin@xxxxxxxxxxxxx>
> ---
> tools/libs/light/libxl_dom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
A note on why you resent would have been useful here. Is this perhaps
more a ping than a resend?
Jan
> diff --git a/tools/libs/light/libxl_dom.c b/tools/libs/light/libxl_dom.c
> index 94fef37401..16aa255aad 100644
> --- a/tools/libs/light/libxl_dom.c
> +++ b/tools/libs/light/libxl_dom.c
> @@ -355,7 +355,7 @@ int libxl__build_pre(libxl__gc *gc, uint32_t domid,
> return ERROR_FAIL;
> }
>
> - if (xc_domain_setmaxmem(ctx->xch, domid, info->target_memkb + size) < 0)
> {
> + if (xc_domain_setmaxmem(ctx->xch, domid, info->max_memkb + size) < 0) {
> LOGE(ERROR, "Couldn't set max memory");
> return ERROR_FAIL;
> }
|
