[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tools: add configure option for libfsimage
- To: Juergen Gross <jgross@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Tue, 8 Aug 2023 11:35:28 +0100
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 08 Aug 2023 10:35:43 +0000
- Ironport-data: A9a23:+bfqqayD6Gk4bTN9ZpZ6t+cWxirEfRIJ4+MujC+fZmUNrF6WrkUEm 2IdWmzVa62Majb2e9Agbdzkp0wA75DVz983HQdp/yAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRuPa8T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVBt1 78mOXMIVTqS19uyy4iqYfdnqtt2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZwMzh/B+ TKWoQwVBDk+a/iH8RSAqUuCreCXxGTWVdg5BOSBo6sCbFq7mTVIVUx+uUGAifu2kEmlQPpEN lcZvCEpqMAa5EGtC9XwQRC8iHqFpQIHHcpdFfUg7wOAwbaS5ByWbkAbShZRZdpgs9U5LRQjz lKTlsnlLSBuuraSD3ma89+pQSiaYHZPazVYPGldEFVDuoO4yG0usv7RZudAMu2Ln57wIhvhk wmOpxIvrKsYodFegs1X4mv7qz6ro5HISCs86QPWQn+p42tFWWK1W2C7wQOFtKgdde51WnHE5 SFZwJbGsIjiGLnXzESwrPMx8KZFDhpvGBnVmhZREpYo7FxBEFbzLNkLsFmSyKqEW/vomAMFg meJ4Wu9B7cJZhNGiJObhKrvY/nGNYC6SbzYugn8N7KimKRZeg6d5z1JbkWNxW3rm0VEufhha M7HKp32XCpKUPQPIN+KqwA1i+ZD+8zD7TmLGcCTI+qPjtJym0J5uZ9aaQDTP4jVHYuPoRnP8 sY3Cid540w3bQEKWQGOqdR7BQlTfRAG6WXe95Q/mhirflA3RwnMypb5ndscRmCSt/8IyrmRp innCxMwJZiWrSSvFDhmo0tLMNvHNauTZ1piVcDwFT5EA0QeXLs=
- Ironport-hdrordr: A9a23:zn3B1KvD6nsNZQQEOhHbbVwk7skDe9V00zEX/kB9WHVpm62j5q OTdZsgvyMc5Ax9ZJhCo7C90cu7L080nKQdieIs1NGZMDUO01HIEGgN1+Tf6gylNQW7y/VU0r 1pebV/Dtr5CDFB/KTH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, Aug 04, 2023 at 08:00:00AM +0200, Juergen Gross wrote:
> The only in-tree user of libfsimage is pygrub. Now that it is possible
> to disable the build of pygrub, the same should be possible for
> libfsimage.
>
> Add an option for controlling the build of libfsimage. The default is
> on if pygrub is being built, and off if it isn't. Without pygrub the
> build of libfsimage can be enabled via --enable-libfsimage.
>
> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
> ---
> diff --git a/tools/configure.ac b/tools/configure.ac
> index 9947bcefc6..aea24eb982 100644
> --- a/tools/configure.ac
> +++ b/tools/configure.ac
> @@ -185,6 +185,19 @@ AS_IF([test "x$enable_rombios" = "xyes"], [
> ])
> AC_SUBST(rombios)
>
> +AC_ARG_ENABLE([libfsimage],
> + AS_HELP_STRING([--enable-libfsimage],
> + [Enable libfsimage, (DEFAULT is on if pygrub is enabled,
> + otherwise off)]),,[
> + AS_IF([test "x$enable_pygrub" = "xno"], [
> + enable_libfsimage="no"
> + ], [
> + enable_libfsimage="yes"
> + ])
> +])
> +AS_IF([test "x$enable_libfsimage" = "xyes"], [libfsimage=y], [libfsimage=n])
> +AC_SUBST(libfsimage)
> +
Should we issue an error if one does "--disable-libfsimage
--enable-pygrub" ? Or just let the build of pygrub fails?
Also, "--disable-libfsimage" alone will keep "pygrub" enabled, so we
should probably check.
Thanks,
--
Anthony PERARD
|
