[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] tools: add configure option for libfsimage
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 8 Aug 2023 11:40:01 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jl16JPyCczFISBufob8qw6MsNZc5UvLU2ffFVK4T680=; b=WtHVnZ73ZTY87/nqvS/vD/x5zbe583u3NZ90q2Xs5oKapvGuuvjm5HlncQ5T+N3Y/W55YP5d7QM/V00U3OmSqgPhpbs0huzMaARqXPvClZDPW3zhO6eYlENo60VfWoOkpS95Afn1u5ha4MuTunxml6CtilrbnWIRFZr51PzrRrKcAnKwkPvIbfZL3GJ0UNhdqmTwwvawL2lzLRf+BdCxmIh3fRExaXt4SnclhBwWoEdvfesKsYqXKPWLKitMIo8cmBXGgfdNXYK0Csh93T01+8V2kvm4j6KDh8bsNGuLgSGDtg0Mdq9RtpEBxTKERDLmm7PLlYyQg9YaJBSIMPKxPw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FtoyHqltReVXrilX14dnd3xGncsBhCDmem5pJtKYeWnhyCklpBlbpYRfMwJq4GMLMYbo+uUWi3KiAnAAX98oMaQUqUoqVhcIsZaNlNADiVNBZZBnpyyncH4I38ZXXGRwi8k4AjsRJG8uX/4YucGF92VTZbjpG/K6rJv2J0Kw1+Y/ry+7OZmeAED6yk7eCdZNDfCclCKiEnR/M1eQQpYDj3YKBTy+N+/U0lU5Bjvz5ZaXt8MlkT8JFXf8/+ef/KcG1FnsSZSQEN89GM3mLve672huxde+6U+/kEqkMVvTTFM9bUIixU51FGrXOJuu2BztAfTsR+BUIvCdWmjoOGVb+A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Wei Liu <wl@xxxxxxx>
- Delivery-date: Tue, 08 Aug 2023 10:40:18 +0000
- Ironport-data: A9a23:0S7z5qsVM2cLCjBC90x/+Rv1L+fnVHVfMUV32f8akzHdYApBsoF/q tZmKTvVMvyDNGL8eY13YYWx9xsF7ZfQzt82SgNo/iphQitA+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5A+GyCFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOmgGYDC6ttON/K+1Ue9gqIczNPOwBdZK0p1g5Wmx4fcOZ7nmGv+Pz/kImTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osjf60b4O9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPOThqaMz3gHNlwT/DjUfR2aLv8idqnK1BfZ/D mtMuXF0hKI9oRnDot7VGkfQTGS/lhwTQd1LCMUh9RqAjKHT5m6xFmUCCzJMdtEinMs3XiAxk E+EmcvzAj5iu6HTTmiSnp+LqRuiNC5TKnUNDRLoViMA6tjn5Ys13hTGS485FLbv14KsXzbt3 zqNsS4ywa0JitIG3Lm6+laBhC+wop/OTUg+4QC/sn+Z0z6VrbWNP+SAgWU3J94aRGpFZjFtZ EQ5pvU=
- Ironport-hdrordr: A9a23:n2/HSqHusLkamEUNpLqE5ceALOsnbusQ8zAXPiFKOH9om6Oj/f xG8M536faWslYssRMb9+xoUZPoKRjhHPhOjbX5Vo3CYOCJggSVBbAnw6On/ibpHDf3/PNc06 BpdsFFeb/NMWQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08/08/2023 11:35 am, Anthony PERARD wrote:
> On Fri, Aug 04, 2023 at 08:00:00AM +0200, Juergen Gross wrote:
>> The only in-tree user of libfsimage is pygrub. Now that it is possible
>> to disable the build of pygrub, the same should be possible for
>> libfsimage.
>>
>> Add an option for controlling the build of libfsimage. The default is
>> on if pygrub is being built, and off if it isn't. Without pygrub the
>> build of libfsimage can be enabled via --enable-libfsimage.
>>
>> Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
>> ---
>> diff --git a/tools/configure.ac b/tools/configure.ac
>> index 9947bcefc6..aea24eb982 100644
>> --- a/tools/configure.ac
>> +++ b/tools/configure.ac
>> @@ -185,6 +185,19 @@ AS_IF([test "x$enable_rombios" = "xyes"], [
>> ])
>> AC_SUBST(rombios)
>>
>> +AC_ARG_ENABLE([libfsimage],
>> + AS_HELP_STRING([--enable-libfsimage],
>> + [Enable libfsimage, (DEFAULT is on if pygrub is enabled,
>> + otherwise off)]),,[
>> + AS_IF([test "x$enable_pygrub" = "xno"], [
>> + enable_libfsimage="no"
>> + ], [
>> + enable_libfsimage="yes"
>> + ])
>> +])
>> +AS_IF([test "x$enable_libfsimage" = "xyes"], [libfsimage=y], [libfsimage=n])
>> +AC_SUBST(libfsimage)
>> +
> Should we issue an error if one does "--disable-libfsimage
> --enable-pygrub" ? Or just let the build of pygrub fails?
In such a case, it wouldn't be a build failure. It would fail at
runtime with an ImportError.
~Andrew
|
