[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 1/3] x86/microcode: Ignore microcode loading interface for revision = -1
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Aug 2023 15:08:04 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0t1G/E/XXCvKHnnjq9IYybPQRG3YkpdsFkUeUcddnQ8=; b=OTKsWTn1i2iYvsrKsfLrW0Dyyo1jx5KApI/9QJ929s6cJCGRt2UqvEvHUQIAqq7uRuK5hTb7dhLE5RhbwlXqrSph0ueSPri7U3QD40HT3DM5ErrUD25oq+VEc/zk1IysJ/ZBZbajLMGeVvjlA1S6xkgY4SiYCHGt7WVZX6v+9T+q6gLaF60dutx8YD+2shm5VtpEqRVq9fMQRgfy3syFm53o/4JBLquIRaxmj7ziIXGsfbV6vjmCNeUaVIfWd++jjyS60So594Xu01SMFIIrqFmzGvXEb9QJs292cJJcgaUq5maZAtzY2iUkjfxnlr5Mfd0+/LRpF8bz+kNKckyT1Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F+1EgTAUNRTc+bj2jM9VqjhwKR+ImArCw3XnHBM/aTbJlrkEKDoCKOXXAsYtiXxyqqRCqNR7zVNjc8cPXgtmWrw2IJkWfP9urGSqd4pAlJ5nXMd1Rv6qE1oqMmOy8ln2Ej3VZQmc64seDkCUEYyPsXIuoPsWZjdthxlpMRkopQPKvzALlnmWmRXxt4+sGv1ndXBTLu50zQ0DxlnL2tNB/xczfRE1yQpy2ZfLQZktLyMr/avFBvazOSjk1L/YEV+pduljaLy7s9dMEYmeeH5kK+FIgMV++N+Smseg/Xyt3zUXu821uCjnHTyZtxQh8WhYHIQwNMmUKvuVuR8DTakgpQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 08 Aug 2023 13:08:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.08.2023 15:03, Alejandro Vallejo wrote:
> --- a/xen/arch/x86/cpu/microcode/core.c
> +++ b/xen/arch/x86/cpu/microcode/core.c
> @@ -867,10 +867,23 @@ int __init early_microcode_init(unsigned long
> *module_map,
> return -ENODEV;
> }
>
> - microcode_grab_module(module_map, mbi);
> -
> ucode_ops.collect_cpu_info();
>
> + /*
> + * Some hypervisors deliberately report a microcode revision of -1 to
> + * mean that they will not accept microcode updates. We take the hint
> + * and ignore the microcode interface in that case.
> + */
> + if ( this_cpu(cpu_sig).rev == ~0 )
> + {
> + printk(XENLOG_WARNING "Microcode loading disabled due to: %s",
> + "rev = ~0");
Sadly there now looks to be a newline missing. Easy to add while committing,
I suppose, and with it added (back)
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
